Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 999573003: [sql] Stop building fts2. (Closed)

Created:
5 years, 9 months ago by Scott Hess - ex-Googler
Modified:
5 years, 9 months ago
Reviewers:
michaeln, scottmg
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Stop building fts2. Long ago, Chromium used fts2 for history full-text search. It was later replaced by fts3, and even later that feature was deleted entirely. fts2 is no longer used in the browser at all, so stop compiling it. Since SQLite is used by WebSQL, in theory this could affect web authors, but WebSQL uses an authorizer to allow only specific virtual table types. fts2 is not one of those types, I have verified manually that fts2 tables cannot be created using WebSQL. BUG=455817 Committed: https://crrev.com/37437cbb433dc0c96691ef7f19880533375703f6 Cr-Commit-Position: refs/heads/master@{#320135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -89 lines) Patch
M build/common.gypi View 4 chunks +0 lines, -8 lines 0 comments Download
M sql/sql.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M sql/sqlite_features_unittest.cc View 1 chunk +10 lines, -28 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 2 chunks +1 line, -18 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Scott Hess - ex-Googler
I think this SQLite thing is going to stick, so might as well land this.
5 years, 9 months ago (2015-03-11 00:04:14 UTC) #2
michaeln
lgtm!!
5 years, 9 months ago (2015-03-11 19:10:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999573003/1
5 years, 9 months ago (2015-03-11 19:38:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/48975)
5 years, 9 months ago (2015-03-11 20:06:45 UTC) #7
Scott Hess - ex-Googler
Err, shoulda seen that coming.
5 years, 9 months ago (2015-03-11 20:10:21 UTC) #9
scottmg
Delete-ings always lgtm.
5 years, 9 months ago (2015-03-11 20:13:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999573003/1
5 years, 9 months ago (2015-03-11 20:15:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 20:24:55 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 20:26:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37437cbb433dc0c96691ef7f19880533375703f6
Cr-Commit-Position: refs/heads/master@{#320135}

Powered by Google App Engine
This is Rietveld 408576698