Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 999553002: Make a material design Input component (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make a material design Input component We don't yet have a focus controller, which means once this control becomes focused there's no way for it to lose focus. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eb20514649fc2a3516feb72c4da49d08db05b08f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -67 lines) Patch
M sky/examples/editor/editable_string.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M sky/examples/editor/editable_text.dart View 3 chunks +30 lines, -57 lines 0 comments Download
M sky/examples/editor/editor_app.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A sky/examples/editor/input.dart View 1 chunk +66 lines, -0 lines 0 comments Download
A sky/examples/editor/keyboard.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-10 21:48:50 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-10 21:54:09 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-10 21:58:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb20514649fc2a3516feb72c4da49d08db05b08f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698