Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 999533002: Don’t const_cast<char*> the service name parameter to bootstrap_look_up() (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Don’t const_cast<char*> the service name parameter to bootstrap_look_up(). This hasn’t been required since the 10.5 SDK, which is no longer supported. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a829f67f8103ff753a798b182c42b7433b90356d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/mac/exception_port_tool.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-10 20:38:09 UTC) #2
Robert Sesek
lgtm
5 years, 9 months ago (2015-03-10 20:39:03 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-10 21:01:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a829f67f8103ff753a798b182c42b7433b90356d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698