Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 99953002: Revert 238143 "Merge 237646 "Ensure that the OSK on Windows 8 sh..." (Closed)

Created:
7 years ago by kareng
Modified:
7 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Revert 238143 "Merge 237646 "Ensure that the OSK on Windows 8 sh..." > Merge 237646 "Ensure that the OSK on Windows 8 shows up when we ..." > > > Ensure that the OSK on Windows 8 shows up when we tap on an editable field in any WebContents. > > > > The current implementation was displaying the OSK only when we tapped on a WebContents hosted by a Browser window. This > > relied on the ChromeRenderViewObserver object in the renderer sending an IPC message ChromeViewHostMsg_FocusedNodeTouched > > which is handled by the Chrome browser code via a WebContentsObserver implementation. > > > > Based on discussions with jam and comments from avi in the review, we decided to implement this functionality in content. > > > > Fixes are as below:- > > 1. We have a new IPc message ViewHostMsg_FocusedNodeTouched which is defined in the view_messages.h file. > > 2. This IPC is sent by the RenderViewImpl::didHandleGestureEvent method if we tapped on an editable field. > > 3, This IPC is handled by the RenderViewHostImpl class. We display the OSK on Windows 8 Aura if a focused editable > > node was tapped. > > 4. The ChromeViewHostMsg_FocusedNodeTouched IPC has been deleted along with the didHandleGestureEvent method in the > > RenderViewObserver interface. > > > > BUG=321576, 319219 > > R=jam@chromium.org, palmer@chromium.org, jam > > TBR=jschuh > > > > Review URL: https://codereview.chromium.org/89873002 > > TBR=ananta@chromium.org > > Review URL: https://codereview.chromium.org/99843002 TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
M chrome/browser/ui/tab_contents/core_tab_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years ago (2013-12-02 19:43:34 UTC) #1
kareng
7 years ago (2013-12-02 19:43:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r238153.

Powered by Google App Engine
This is Rietveld 408576698