Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 999523002: Add dpranke as an OWNER to the top-level GN and GYP files for the GN migration. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
brettw, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dpranke as an OWNER to the top-level GN and GYP files for the GN migration. (src/BUILD.gn and src/build). Since he's the main one tracking the migration. R=jam@chromium.org TBR=brettw@chromium.org BUG=461019 Committed: https://crrev.com/e3b19992280a9d95c72c2600bea97a0cc0acab11 Cr-Commit-Position: refs/heads/master@{#319979}

Patch Set 1 #

Total comments: 2

Patch Set 2 : make dpranke own all of //build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M build/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
5 years, 9 months ago (2015-03-10 20:40:27 UTC) #1
jam
lgtm https://codereview.chromium.org/999523002/diff/1/build/OWNERS File build/OWNERS (right): https://codereview.chromium.org/999523002/diff/1/build/OWNERS#newcode6 build/OWNERS:6: per-file gn_migration.gypi=dpranke@chromium.org i think you should be owner ...
5 years, 9 months ago (2015-03-10 20:50:17 UTC) #2
Dirk Pranke
https://codereview.chromium.org/999523002/diff/1/build/OWNERS File build/OWNERS (right): https://codereview.chromium.org/999523002/diff/1/build/OWNERS#newcode6 build/OWNERS:6: per-file gn_migration.gypi=dpranke@chromium.org On 2015/03/10 20:50:17, jam wrote: > i ...
5 years, 9 months ago (2015-03-10 21:08:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999523002/20001
5 years, 9 months ago (2015-03-10 21:09:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 21:37:27 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 21:38:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3b19992280a9d95c72c2600bea97a0cc0acab11
Cr-Commit-Position: refs/heads/master@{#319979}

Powered by Google App Engine
This is Rietveld 408576698