ui/events/gesture_detection/motion_event.h - Issue 999423003: Set the unique_event_id when converting from TouchEvent to WebTouchEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/motion_event.h

Issue 999423003: Set the unique_event_id when converting from TouchEvent to WebTouchEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/events/base_event_utils.cc ('K') | « ui/events/gesture_detection/gesture_provider_unittest.cc ('k') | ui/events/gesture_detection/motion_event_buffer.cc » ('j') | ui/events/gesture_detection/motion_event_generic.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/gesture_detection/motion_event.h

diff --git a/ui/events/gesture_detection/motion_event.h b/ui/events/gesture_detection/motion_event.h

index 560afcbd044c20155ed281e7762f33ddbba77bb7..1dbac1c732491e72d2a437e89f1e6072c94c4bef 100644

--- a/ui/events/gesture_detection/motion_event.h

+++ b/ui/events/gesture_detection/motion_event.h

@@ -46,7 +46,9 @@ class GESTURE_DETECTION_EXPORT MotionEvent {

virtual ~MotionEvent() {}

- virtual int GetId() const = 0;

jdduke (slow) 2015/04/21 22:40:16 Nit: delete this extra newline.

lanwei 2015/04/22 20:51:31 Done.

+ // An unique identifier this motion event.

+ virtual uint64 GetUniqueEventId() const = 0;

virtual Action GetAction() const = 0;

// Only valid if |GetAction()| returns ACTION_POINTER_UP or

// ACTION_POINTER_DOWN.

@@ -80,6 +82,7 @@ class GESTURE_DETECTION_EXPORT MotionEvent {

virtual int GetSourceDeviceId(size_t pointer_index) const;

// Utility accessor methods for convenience.

+ int GetPointerId() const { return GetPointerId(0); }

float GetX() const { return GetX(0); }

float GetY() const { return GetY(0); }

float GetRawX() const { return GetRawX(0); }