Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: ui/events/gesture_detection/motion_event_generic_unittest.cc

Issue 999423003: Set the unique_event_id when converting from TouchEvent to WebTouchEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "testing/gtest/include/gtest/gtest.h" 5 #include "testing/gtest/include/gtest/gtest.h"
6 #include "ui/events/event_constants.h" 6 #include "ui/events/event_constants.h"
7 #include "ui/events/gesture_detection/motion_event_generic.h" 7 #include "ui/events/gesture_detection/motion_event_generic.h"
8 #include "ui/events/test/motion_event_test_utils.h" 8 #include "ui/events/test/motion_event_test_utils.h"
9 9
10 namespace ui { 10 namespace ui {
11 11
12 TEST(MotionEventGenericTest, Basic) { 12 TEST(MotionEventGenericTest, Basic) {
13 base::TimeTicks event_time = base::TimeTicks::Now(); 13 base::TimeTicks event_time = base::TimeTicks::Now();
14 MotionEventGeneric event( 14 MotionEventGeneric event(
15 MotionEvent::ACTION_DOWN, event_time, PointerProperties()); 15 MotionEvent::ACTION_DOWN, event_time, PointerProperties());
16 EXPECT_EQ(1U, event.GetPointerCount()); 16 EXPECT_EQ(1U, event.GetPointerCount());
17 EXPECT_EQ(0U, event.GetHistorySize()); 17 EXPECT_EQ(0U, event.GetHistorySize());
18 EXPECT_EQ(event_time, event.GetEventTime()); 18 EXPECT_EQ(event_time, event.GetEventTime());
19 19
20 DCHECK_NE(0U, event.GetUniqueEventId());
21 event.set_unique_event_id(123456U);
22 EXPECT_EQ(123456U, event.GetUniqueEventId());
23
20 event.PushPointer(PointerProperties(8.3f, 4.7f, 0.9f)); 24 event.PushPointer(PointerProperties(8.3f, 4.7f, 0.9f));
21 ASSERT_EQ(2U, event.GetPointerCount()); 25 ASSERT_EQ(2U, event.GetPointerCount());
22 EXPECT_EQ(8.3f, event.GetX(1)); 26 EXPECT_EQ(8.3f, event.GetX(1));
23 EXPECT_EQ(4.7f, event.GetY(1)); 27 EXPECT_EQ(4.7f, event.GetY(1));
24 28
25 event.PushPointer(PointerProperties(2.3f, -3.7f, 5.8f)); 29 event.PushPointer(PointerProperties(2.3f, -3.7f, 5.8f));
26 ASSERT_EQ(3U, event.GetPointerCount()); 30 ASSERT_EQ(3U, event.GetPointerCount());
27 EXPECT_EQ(2.3f, event.GetX(2)); 31 EXPECT_EQ(2.3f, event.GetX(2));
28 EXPECT_EQ(-3.7f, event.GetY(2)); 32 EXPECT_EQ(-3.7f, event.GetY(2));
29 33
30 event.set_id(1); 34 event.pointer(0).id = 3;
31 EXPECT_EQ(1, event.GetId()); 35 EXPECT_EQ(3, event.GetPointerId(0));
32 36
33 event.set_action(MotionEvent::ACTION_POINTER_DOWN); 37 event.set_action(MotionEvent::ACTION_POINTER_DOWN);
34 EXPECT_EQ(MotionEvent::ACTION_POINTER_DOWN, event.GetAction()); 38 EXPECT_EQ(MotionEvent::ACTION_POINTER_DOWN, event.GetAction());
35 39
36 event_time += base::TimeDelta::FromMilliseconds(5); 40 event_time += base::TimeDelta::FromMilliseconds(5);
37 event.set_event_time(event_time); 41 event.set_event_time(event_time);
38 EXPECT_EQ(event_time, event.GetEventTime()); 42 EXPECT_EQ(event_time, event.GetEventTime());
39 43
40 event.set_button_state(MotionEvent::BUTTON_PRIMARY); 44 event.set_button_state(MotionEvent::BUTTON_PRIMARY);
41 EXPECT_EQ(MotionEvent::BUTTON_PRIMARY, event.GetButtonState()); 45 EXPECT_EQ(MotionEvent::BUTTON_PRIMARY, event.GetButtonState());
(...skipping 26 matching lines...) Expand all
68 EXPECT_EQ(1.f, event.GetHistoricalTouchMajor(0, 0)); 72 EXPECT_EQ(1.f, event.GetHistoricalTouchMajor(0, 0));
69 EXPECT_EQ(2.4f, event.GetHistoricalX(1, 0)); 73 EXPECT_EQ(2.4f, event.GetHistoricalX(1, 0));
70 EXPECT_EQ(4.8f, event.GetHistoricalY(1, 0)); 74 EXPECT_EQ(4.8f, event.GetHistoricalY(1, 0));
71 EXPECT_EQ(2.f, event.GetHistoricalTouchMajor(1, 0)); 75 EXPECT_EQ(2.f, event.GetHistoricalTouchMajor(1, 0));
72 EXPECT_EQ(4.8f, event.GetHistoricalX(2, 0)); 76 EXPECT_EQ(4.8f, event.GetHistoricalX(2, 0));
73 EXPECT_EQ(9.6f, event.GetHistoricalY(2, 0)); 77 EXPECT_EQ(9.6f, event.GetHistoricalY(2, 0));
74 EXPECT_EQ(3.f, event.GetHistoricalTouchMajor(2, 0)); 78 EXPECT_EQ(3.f, event.GetHistoricalTouchMajor(2, 0));
75 } 79 }
76 80
77 TEST(MotionEventGenericTest, Clone) { 81 TEST(MotionEventGenericTest, Clone) {
78 MotionEventGeneric event(MotionEvent::ACTION_DOWN, 82 MotionEventGeneric event(MotionEvent::ACTION_DOWN,
jdduke (slow) 2015/04/27 17:11:07 Can you make sure the event id is cloned for Clone
lanwei 2015/04/28 16:24:35 Done.
79 base::TimeTicks::Now(), 83 base::TimeTicks::Now(),
80 PointerProperties(8.3f, 4.7f, 2.f)); 84 PointerProperties(8.3f, 4.7f, 2.f));
81 event.set_id(1);
82 event.set_button_state(MotionEvent::BUTTON_PRIMARY); 85 event.set_button_state(MotionEvent::BUTTON_PRIMARY);
83 86
84 scoped_ptr<MotionEvent> clone = event.Clone(); 87 scoped_ptr<MotionEvent> clone = event.Clone();
85 ASSERT_TRUE(clone); 88 ASSERT_TRUE(clone);
86 EXPECT_EQ(test::ToString(event), test::ToString(*clone)); 89 EXPECT_EQ(test::ToString(event), test::ToString(*clone));
87 } 90 }
88 91
89 TEST(MotionEventGenericTest, CloneWithHistory) { 92 TEST(MotionEventGenericTest, CloneWithHistory) {
90 base::TimeTicks event_time = base::TimeTicks::Now(); 93 base::TimeTicks event_time = base::TimeTicks::Now();
91 base::TimeTicks historical_event_time = 94 base::TimeTicks historical_event_time =
(...skipping 11 matching lines...) Expand all
103 106
104 scoped_ptr<MotionEvent> clone = event.Clone(); 107 scoped_ptr<MotionEvent> clone = event.Clone();
105 ASSERT_TRUE(clone); 108 ASSERT_TRUE(clone);
106 EXPECT_EQ(test::ToString(event), test::ToString(*clone)); 109 EXPECT_EQ(test::ToString(event), test::ToString(*clone));
107 } 110 }
108 111
109 TEST(MotionEventGenericTest, Cancel) { 112 TEST(MotionEventGenericTest, Cancel) {
110 MotionEventGeneric event(MotionEvent::ACTION_UP, 113 MotionEventGeneric event(MotionEvent::ACTION_UP,
111 base::TimeTicks::Now(), 114 base::TimeTicks::Now(),
112 PointerProperties(8.7f, 4.3f, 1.f)); 115 PointerProperties(8.7f, 4.3f, 1.f));
113 event.set_id(2);
114 event.set_button_state(MotionEvent::BUTTON_SECONDARY); 116 event.set_button_state(MotionEvent::BUTTON_SECONDARY);
115 117
116 scoped_ptr<MotionEvent> cancel = event.Cancel(); 118 scoped_ptr<MotionEvent> cancel = event.Cancel();
117 event.set_action(MotionEvent::ACTION_CANCEL); 119 event.set_action(MotionEvent::ACTION_CANCEL);
118 ASSERT_TRUE(cancel); 120 ASSERT_TRUE(cancel);
119 EXPECT_EQ(test::ToString(event), test::ToString(*cancel)); 121 EXPECT_EQ(test::ToString(event), test::ToString(*cancel));
120 } 122 }
121 123
122 TEST(MotionEventGenericTest, FindPointerIndexOfId) { 124 TEST(MotionEventGenericTest, FindPointerIndexOfId) {
123 base::TimeTicks event_time = base::TimeTicks::Now(); 125 base::TimeTicks event_time = base::TimeTicks::Now();
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 ASSERT_EQ(2U, event.GetHistorySize()); 215 ASSERT_EQ(2U, event.GetHistorySize());
214 ASSERT_EQ(2U, event.GetPointerCount()); 216 ASSERT_EQ(2U, event.GetPointerCount());
215 217
216 // Do a basic smoke exercise of event stringification to ensure things don't 218 // Do a basic smoke exercise of event stringification to ensure things don't
217 // explode in the process. 219 // explode in the process.
218 std::string event_string = test::ToString(event); 220 std::string event_string = test::ToString(event);
219 EXPECT_FALSE(event_string.empty()); 221 EXPECT_FALSE(event_string.empty());
220 } 222 }
221 223
222 } // namespace ui 224 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698