Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 999353005: Land Recent QUIC Changes (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes Remove Balsa from QuicSpdyServerStream. Merge internal change: 89412730 https://codereview.chromium.org/1033833003/ Make initialization of the QuicInMemoryCache explicit to avoid spooky action at a distance which complicates testing. Merge internal change: 89416965 https://codereview.chromium.org/1037533002/ Change the QuicInMemoryCache to store a SpdyHeaderBlock instead of BalsaHeaders. This saves various round trips between the two representations and will make it easier to port to Chromium which does not use BalsaHeader (in the main codebase). Merge internal change: 89410736 https://codereview.chromium.org/1036643003/ Remove the QuicDispatcher's explicit use of EpollServer. To facilitate landing actual QuicServer support in Chromium using Chromium's MessageLoop and friends. Merge internal change: 89309068 https://codereview.chromium.org/1030023002/ Remove the QuicTimeWaitListManager's explicit use of EpollServer. To facilitate landing actual QuicServer support in Chromium using Chromium's MessageLoop and friends. Merge internal change: 89298502 https://codereview.chromium.org/1034573002/ Improve QUIC tests. Correct things clang_tidy complains about. Make QuicTimeWaitListManager::AddConnectionIdToTimeWait virtual so it can be mocked. Correct things clang_tidy complains about. Make a method virtual so it can be mocked. Merge internal change: 88744988 https://codereview.chromium.org/1034573002/ Committed: https://crrev.com/cd3123fe58119c96a6f6bed94ba9732fc4257e35 Cr-Commit-Position: refs/heads/master@{#322134}

Patch Set 1 #

Patch Set 2 : Fix comments #

Patch Set 3 : remove epoll #

Patch Set 4 : remove balsa #

Patch Set 5 : wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -336 lines) Patch
M net/data/quic_in_memory_cache_data/quic-datatesturl.com/index.html View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 6 chunks +8 lines, -17 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 5 chunks +19 lines, -12 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 8 chunks +13 lines, -20 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 7 chunks +14 lines, -17 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 1 9 chunks +38 lines, -33 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache_test.cc View 3 chunks +30 lines, -26 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server.cc View 4 chunks +13 lines, -4 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream.h View 1 2 3 3 chunks +9 lines, -10 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 1 2 3 4 4 chunks +56 lines, -55 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 8 chunks +50 lines, -68 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 5 chunks +23 lines, -26 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 2 6 chunks +27 lines, -28 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 9 chunks +12 lines, -8 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +16 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ryan Hamilton
5 years, 9 months ago (2015-03-25 04:52:10 UTC) #2
ramant (doing other things)
lgtm
5 years, 9 months ago (2015-03-25 06:03:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999353005/60001
5 years, 9 months ago (2015-03-25 06:04:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51756)
5 years, 9 months ago (2015-03-25 06:11:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999353005/80001
5 years, 9 months ago (2015-03-25 06:57:16 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-25 09:36:31 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 09:37:29 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cd3123fe58119c96a6f6bed94ba9732fc4257e35
Cr-Commit-Position: refs/heads/master@{#322134}

Powered by Google App Engine
This is Rietveld 408576698