Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: src/opts/SkBlurImage_opts_neon.cpp

Issue 99933004: Implement a NEON version of the RGBA gaussian blur. This shows a 9-15% speedup on Nexus-10. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Moar vector comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/opts.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/opts/SkBlurImage_opts_neon.cpp
diff --git a/src/opts/SkBlurImage_opts_neon.cpp b/src/opts/SkBlurImage_opts_neon.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..a1d9cc18acdf95750328832405a9d8908cfc2d21
--- /dev/null
+++ b/src/opts/SkBlurImage_opts_neon.cpp
@@ -0,0 +1,104 @@
+/*
+ * Copyright 2013 The Android Open Source Project
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+
+#include "SkBitmap.h"
+#include "SkColorPriv.h"
+#include "SkBlurImage_opts.h"
+#include "SkRect.h"
+
+#include <arm_neon.h>
+
+namespace {
+
+enum BlurDirection {
+ kX, kY
+};
+
+/**
+ * Helper function to spread the components of a 32-bit integer into the
+ * lower 8 bits of each 32-bit element of a NEON register.
+ */
+
+inline uint32x4_t expand(uint32_t a) {
+ // ( ARGB ) -> ( ARGB ARGB ) -> ( A R G B A R G B )
+ uint8x8_t v8 = vreinterpret_u8_u32(vdup_n_u32(a));
+ // ( A R G B A R G B ) -> ( 0A 0R 0G 0B 0A 0R 0G 0B ) -> ( 0A 0R 0G 0B )
+ const uint16x4_t v16 = vget_low_u16(vmovl_u8(v8));
+ // ( 0A 0R 0G 0B ) -> ( 000A 000R 000G 000B )
+ return vmovl_u16(v16);
+}
+
+template<BlurDirection srcDirection, BlurDirection dstDirection>
+void SkBoxBlur_NEON(const SkPMColor* src, int srcStride, SkPMColor* dst, int kernelSize,
+ int leftOffset, int rightOffset, int width, int height)
+{
+ const int rightBorder = SkMin32(rightOffset + 1, width);
+ const int srcStrideX = srcDirection == kX ? 1 : srcStride;
+ const int dstStrideX = dstDirection == kX ? 1 : height;
+ const int srcStrideY = srcDirection == kX ? srcStride : 1;
+ const int dstStrideY = dstDirection == kX ? width : 1;
+ const uint32x4_t scale = vdupq_n_u32((1 << 24) / kernelSize);
+ const uint32x4_t half = vdupq_n_u32(1 << 23);
+ for (int y = 0; y < height; ++y) {
+ uint32x4_t sum = vdupq_n_u32(0);
+ const SkPMColor* p = src;
+ for (int i = 0; i < rightBorder; ++i) {
+ sum = vaddq_u32(sum, expand(*p));
+ p += srcStrideX;
+ }
+
+ const SkPMColor* sptr = src;
+ SkPMColor* dptr = dst;
+ for (int x = 0; x < width; ++x) {
+ // ( half+sumA*scale half+sumR*scale half+sumG*scale half+sumB*scale )
+ uint32x4_t result = vmlaq_u32(half, sum, scale);
+
+ // Shift down to lower 8 bits of each element.
+ // ( AAAA RRRR GGGG BBBB ) -> ( 000A 000R 000G 000B )
+ result = vshrq_n_u32(result, 24);
+
+ // ( 000A 000R 000G 000B ) -> ( 0A 0R 0G 0B )
+ uint16x4_t result16 = vqmovn_u32(result);
+
+ // ( 0A 0R 0G 0B ) -> ( 0A 0R 0G 0B 0A 0R 0G 0B ) -> ( A R G B A R G B )
+ uint8x8_t result8 = vqmovn_u16(vcombine_u16(result16, result16));
+
+ // ( A R G B A R G B ) -> ( ARGB ARGB ) -> ( ARGB )
+ // Store low 32 bits to destination.
+ vst1_lane_u32(dptr, vreinterpret_u32_u8(result8), 0);
+ if (x >= leftOffset) {
+ const SkPMColor* l = sptr - leftOffset * srcStrideX;
+ sum = vsubq_u32(sum, expand(*l));
+ }
+ if (x + rightOffset + 1 < width) {
+ const SkPMColor* r = sptr + (rightOffset + 1) * srcStrideX;
+ sum = vaddq_u32(sum, expand(*r));
+ }
+ sptr += srcStrideX;
+ if (srcDirection == kY) {
+ SK_PREFETCH(sptr + (rightOffset + 1) * srcStrideX);
+ }
+ dptr += dstStrideX;
+ }
+ src += srcStrideY;
+ dst += dstStrideY;
+ }
+}
+
+} // namespace
+
+bool SkBoxBlurGetPlatformProcs(SkBoxBlurProc* boxBlurX,
+ SkBoxBlurProc* boxBlurY,
+ SkBoxBlurProc* boxBlurXY,
+ SkBoxBlurProc* boxBlurYX) {
+ *boxBlurX = SkBoxBlur_NEON<kX, kX>;
+ *boxBlurY = SkBoxBlur_NEON<kY, kY>;
+ *boxBlurXY = SkBoxBlur_NEON<kX, kY>;
+ *boxBlurYX = SkBoxBlur_NEON<kY, kX>;
+ return true;
+}
« no previous file with comments | « gyp/opts.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698