Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: gyp/opts.gyp

Issue 99933004: Implement a NEON version of the RGBA gaussian blur. This shows a 9-15% speedup on Nexus-10. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Fixes per review comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/opts/SkBlurImage_opts_neon.cpp » ('j') | src/opts/SkBlurImage_opts_neon.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'targets': [ 2 'targets': [
3 # Due to an unfortunate intersection of lameness between gcc and gyp, 3 # Due to an unfortunate intersection of lameness between gcc and gyp,
4 # we have to build the *_SSE2.cpp files in a separate target. The 4 # we have to build the *_SSE2.cpp files in a separate target. The
5 # gcc lameness is that, in order to compile SSE2 intrinsics code, it 5 # gcc lameness is that, in order to compile SSE2 intrinsics code, it
6 # must be passed the -msse2 flag. However, with this flag, it may 6 # must be passed the -msse2 flag. However, with this flag, it may
7 # emit SSE2 instructions even for scalar code, such as the CPUID 7 # emit SSE2 instructions even for scalar code, such as the CPUID
8 # test used to test for the presence of SSE2. So that, and all other 8 # test used to test for the presence of SSE2. So that, and all other
9 # code must be compiled *without* -msse2. The gyp lameness is that it 9 # code must be compiled *without* -msse2. The gyp lameness is that it
10 # does not allow file-specific CFLAGS, so we must create this extra 10 # does not allow file-specific CFLAGS, so we must create this extra
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 'variables': { 72 'variables': {
73 'arm_neon_optional%': '<(arm_neon_optional>', 73 'arm_neon_optional%': '<(arm_neon_optional>',
74 }, 74 },
75 'sources': [ 75 'sources': [
76 '../src/opts/opts_check_arm.cpp', 76 '../src/opts/opts_check_arm.cpp',
77 '../src/opts/memset.arm.S', 77 '../src/opts/memset.arm.S',
78 '../src/opts/SkBitmapProcState_opts_arm.cpp', 78 '../src/opts/SkBitmapProcState_opts_arm.cpp',
79 '../src/opts/SkBlitMask_opts_arm.cpp', 79 '../src/opts/SkBlitMask_opts_arm.cpp',
80 '../src/opts/SkBlitRow_opts_arm.cpp', 80 '../src/opts/SkBlitRow_opts_arm.cpp',
81 '../src/opts/SkBlitRow_opts_arm.h', 81 '../src/opts/SkBlitRow_opts_arm.h',
82 '../src/opts/SkBlurImage_opts_none.cpp',
83 '../src/opts/SkXfermode_opts_arm.cpp', 82 '../src/opts/SkXfermode_opts_arm.cpp',
84 ], 83 ],
85 'conditions': [ 84 'conditions': [
86 [ 'arm_neon == 1 or arm_neon_optional == 1', { 85 [ 'arm_neon == 1 or arm_neon_optional == 1', {
87 'dependencies': [ 86 'dependencies': [
88 'opts_neon', 87 'opts_neon',
89 ] 88 ]
90 }], 89 }],
91 [ 'skia_os == "ios"', { 90 [ 'skia_os == "ios"', {
92 'sources!': [ 91 'sources!': [
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 ], 171 ],
173 'sources': [ 172 'sources': [
174 '../src/opts/memset16_neon.S', 173 '../src/opts/memset16_neon.S',
175 '../src/opts/memset32_neon.S', 174 '../src/opts/memset32_neon.S',
176 '../src/opts/SkBitmapProcState_arm_neon.cpp', 175 '../src/opts/SkBitmapProcState_arm_neon.cpp',
177 '../src/opts/SkBitmapProcState_matrixProcs_neon.cpp', 176 '../src/opts/SkBitmapProcState_matrixProcs_neon.cpp',
178 '../src/opts/SkBitmapProcState_matrix_clamp_neon.h', 177 '../src/opts/SkBitmapProcState_matrix_clamp_neon.h',
179 '../src/opts/SkBitmapProcState_matrix_repeat_neon.h', 178 '../src/opts/SkBitmapProcState_matrix_repeat_neon.h',
180 '../src/opts/SkBlitMask_opts_arm_neon.cpp', 179 '../src/opts/SkBlitMask_opts_arm_neon.cpp',
181 '../src/opts/SkBlitRow_opts_arm_neon.cpp', 180 '../src/opts/SkBlitRow_opts_arm_neon.cpp',
181 '../src/opts/SkBlurImage_opts_neon.cpp',
182 '../src/opts/SkMorphology_opts_neon.cpp', 182 '../src/opts/SkMorphology_opts_neon.cpp',
183 '../src/opts/SkXfermode_opts_arm_neon.cpp', 183 '../src/opts/SkXfermode_opts_arm_neon.cpp',
184 ], 184 ],
185 }, 185 },
186 ], 186 ],
187 } 187 }
OLDNEW
« no previous file with comments | « no previous file | src/opts/SkBlurImage_opts_neon.cpp » ('j') | src/opts/SkBlurImage_opts_neon.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698