native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_resource_manager.h - Issue 99933002: [NaCl SDK] nacl_io: implement getaddrinfo()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_resource_manager.h

Issue 99933002: [NaCl SDK] nacl_io: implement getaddrinfo() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_host_resolver_interface.cc ('K') | « native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_net_address_interface.cc ('k') | native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_resource_manager.cc » ('j') | native_client_sdk/src/tests/nacl_io_test/host_resolver_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_resource_manager.h

diff --git a/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_resource_manager.h b/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_resource_manager.h

index 10e1d6eac2071816ebcbfc2e26e9ec3276d312c5..eda20be799f2b5cfde106fb6300f561cfd76309c 100644

--- a/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_resource_manager.h

+++ b/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_resource_manager.h

@@ -31,7 +31,7 @@ class FakeResourceManager {

T* Get(PP_Resource handle);

private:

- FakeResourceTracker* Get(PP_Resource handle);

+ FakeResourceTracker* Get(PP_Resource handle, bool silent=false);

binji 2014/01/29 19:18:52 I don't like bool parameters to functions; can you

Sam Clegg 2014/01/29 22:06:13 I just reverted this part of the change

typedef std::map<PP_Resource, FakeResourceTracker*> ResourceMap;

PP_Resource next_handle_;