Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 999273003: Revert of Debugger: deduplicate shared function info when setting script break points. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Debugger: deduplicate shared function info when setting script break points. (patchset #4 id:60001 of https://codereview.chromium.org/998253005/) Reason for revert: Code caching failures. Original issue's description: > Debugger: deduplicate shared function info when setting script break points. > > Also fix Debug.showBreakPoints for multiple break points at the same location. > > BUG=v8:3960 > LOG=N > > Committed: https://crrev.com/73b17a71a22564c0b66d9aa7c00948c748f5b290 > Cr-Commit-Position: refs/heads/master@{#27444} TBR=mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3960 Committed: https://crrev.com/9b29d008dfcc00bf56be8040add1d2c5e404673b Cr-Commit-Position: refs/heads/master@{#27448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -77 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 3 chunks +14 lines, -27 lines 0 comments Download
M src/liveedit.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/debug-liveedit-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-liveedit-4.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/regress/regress-3960.js View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
Created Revert of Debugger: deduplicate shared function info when setting script break points.
5 years, 9 months ago (2015-03-25 15:18:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999273003/1
5 years, 9 months ago (2015-03-25 15:18:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 15:19:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b29d008dfcc00bf56be8040add1d2c5e404673b Cr-Commit-Position: refs/heads/master@{#27448}
5 years, 9 months ago (2015-03-25 15:19:30 UTC) #4
Michael Starzinger
LGTM (rubber-stamped).
5 years, 9 months ago (2015-03-25 15:37:38 UTC) #5
Yang
5 years, 9 months ago (2015-03-26 09:57:35 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1037013002/ by yangguo@chromium.org.

The reason for reverting is: Reland since the failure has been fixed in
https://codereview.chromium.org/1035523005/.

Powered by Google App Engine
This is Rietveld 408576698