tools/perf/page_sets/diagonal_scrolling_supported_shared_state.py - Issue 999243003: Adding tests for diagonal scrolling in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/diagonal_scrolling_supported_shared_state.py

Issue 999243003: Adding tests for diagonal scrolling in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing python lists to tuple, changing comment indentation, and changing a test to only run on ch… Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/diagonal_scrolling_supported_shared_state.py

diff --git a/tools/perf/page_sets/fling_gesture_supported_shared_state.py b/tools/perf/page_sets/diagonal_scrolling_supported_shared_state.py

similarity index 54%

copy from tools/perf/page_sets/fling_gesture_supported_shared_state.py

copy to tools/perf/page_sets/diagonal_scrolling_supported_shared_state.py

index 3d40a6c7ca717ced706476a3e3c0feff9d6a4387..969fca8230427d1754796a28be46b642d8386922 100644

--- a/tools/perf/page_sets/fling_gesture_supported_shared_state.py

+++ b/tools/perf/page_sets/diagonal_scrolling_supported_shared_state.py

@@ -6,9 +6,10 @@ import logging

from telemetry.page import shared_page_state

-class FlingGestureSupportedSharedState(shared_page_state.SharedPageState):

+class DiagonalScrollingSupportedSharedState(shared_page_state.SharedPageState):

def CanRunOnBrowser(self, browser_info):

- if not browser_info.HasFlingGestureSupport():

- logging.warning('Browser does not support fling gestures, skipping test')

+ if not browser_info.HasDiagonalScrollingSupport():

+ logging.warning('Browser does not support synthetic diagonal scrolling,'

+ ' skipping test')

return False

return True