Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: Source/devtools/front_end/networkLogView.css

Issue 99923009: DevTools: network log bars use CSS instead of pre-rendered images. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed broken test. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/networkLogView.css
diff --git a/Source/devtools/front_end/networkLogView.css b/Source/devtools/front_end/networkLogView.css
index c34afbc812f6655b29314df3e3bd31a8e56fecfb..4764904c6ef554b4e9a1d73d59b225ef1a40d62d 100644
--- a/Source/devtools/front_end/networkLogView.css
+++ b/Source/devtools/front_end/networkLogView.css
@@ -343,11 +343,16 @@
top: 0;
bottom: 0;
margin: auto -7px;
- border-width: 6px 7px;
- height: 0;
+ height: 12px;
min-width: 14px;
opacity: 0.65;
- -webkit-border-image: url(Images/timelinePillGray.png) 7 7 7 7;
+ border-width: 1px;
+ border-style: solid;
+ border-radius: 7px / 6px;
+ box-shadow: inset 0 1px 1px 0px rgba(255, 255, 255, 0.8);
+
+ border-color: hsl(0, 0%, 65%);
+ background: linear-gradient(0deg, hsl(0, 0%, 73%), hsl(0, 0%, 78%));
}
.network-graph-bar.waiting,
@@ -359,63 +364,100 @@
.resource-cached .network-graph-bar {
- -webkit-border-image: url(Images/timelineHollowPillGray.png) 7 7 7 7;
+ border-color: hsl(0, 0%, 66%);
+ background: hsla(0, 0%, 78%, 0.45);
+ box-shadow: inset 0 1px 1px 0px rgba(255, 255, 255, 0.8),
+ inset 0 0 0 2px hsl(0, 0%, 73%),
+ inset 0 1px 0 2px hsla(0, 0%, 76%, 0.85);
}
.network-type-document .network-graph-bar {
- -webkit-border-image: url(Images/timelinePillBlue.png) 7 7 7 7;
+ border-color: hsl(215, 49%, 52%);
+ background: linear-gradient(0deg, hsl(215, 72%, 61%), hsl(215, 100%, 69%));
}
.network-type-document.resource-cached .network-graph-bar {
- -webkit-border-image: url(Images/timelineHollowPillBlue.png) 7 7 7 7;
+ border-color: hsl(215, 48%, 52%);
eustas 2013/12/26 05:13:58 Do we need to redefine border-color in .resource-c
pwnall-personal 2013/12/26 05:39:57 A couple of bars have the same border color, but m
+ background: hsla(215, 99%, 69%, 0.45);
+ box-shadow: inset 0 1px 1px 0px rgba(255, 255, 255, 0.8),
+ inset 0 0 0 2px hsl(215, 71%, 61%),
eustas 2013/12/26 05:13:58 AFAIR, we prefer rgb/rgba for color. (Though a lit
pwnall-personal 2013/12/26 05:39:57 I used HSL because all the colors in a bar have th
+ inset 0 1px 0 2px hsla(215, 58%, 65%, 0.85);
}
.network-type-stylesheet .network-graph-bar {
- -webkit-border-image: url(Images/timelinePillGreen.png) 7 7 7 7;
+ border-color: hsl(99, 34%, 52%);
+ background: linear-gradient(0deg, hsl(100, 50%, 61%), hsl(90, 50%, 64%));
}
.network-type-stylesheet.resource-cached .network-graph-bar {
- -webkit-border-image: url(Images/timelineHollowPillGreen.png) 7 7 7 7;
+ border-color: hsl(99, 49%, 52%);
+ background: hsla(99, 100%, 69%, 0.45);
+ box-shadow: inset 0 1px 1px 0px rgba(255, 255, 255, 0.8),
eustas 2013/12/26 05:13:58 Can't shadow be unified for all .resource-cached?
pwnall-personal 2013/12/26 05:39:57 I did this to reproduce the .png files as accurate
pwnall-personal 2013/12/26 15:44:05 Here is the best I could get: https://drive.googl
+ inset 0 0 0 2px hsl(99, 72%, 61%),
+ inset 0 1px 0 2px hsla(99, 59%, 65%, 0.85);
}
.network-type-image .network-graph-bar {
- -webkit-border-image: url(Images/timelinePillPurple.png) 6 7 6 7;
+ border-color: hsl(272, 31%, 52%);
+ background: linear-gradient(0deg, hsl(272, 46%, 61%), hsl(272, 64%, 69%));
}
.network-type-image.resource-cached .network-graph-bar {
- border-image: url(Images/timelineHollowPillPurple.png) 7 7 7 7;
+ border-color: hsl(272, 32%, 52%);
+ background: hsla(272, 65%, 69%, 0.45);
+ box-shadow: inset 0 1px 1px 0px rgba(255, 255, 255, 0.8),
+ inset 0 0 0 2px hsl(272, 47%, 61%),
+ inset 0 1px 0 2px hsla(273, 38%, 65%, 0.85);
}
.network-type-font .network-graph-bar {
- -webkit-border-image: url(Images/timelinePillRed.png) 7 7 7 7;
+ border-color: hsl(8, 49%, 52%);
+ background: linear-gradient(0deg, hsl(8, 72%, 61%), hsl(8, 100%, 69%));
}
.network-type-font.resource-cached .network-graph-bar {
- -webkit-border-image: url(Images/timelineHollowPillRed.png) 7 7 7 7;
+ border-color: hsl(8, 49%, 52%);
+ background: hsla(8, 100%, 69%, 0.45);
+ box-shadow: inset 0 1px 1px 0px rgba(255, 255, 255, 0.8),
+ inset 0 0 0 2px hsl(8, 72%, 61%),
+ inset 0 1px 0 2px hsla(8, 59%, 65%, 0.85);
}
.network-type-script .network-graph-bar {
- -webkit-border-image: url(Images/timelinePillOrange.png) 7 7 7 7;
+ border-color: hsl(31, 49%, 52%);
+ background: linear-gradient(0deg, hsl(31, 72%, 61%), hsl(31, 100%, 69%));
}
.network-type-script.resource-cached .network-graph-bar {
- -webkit-border-image: url(Images/timelineHollowPillOrange.png) 7 7 7 7;
+ border-color: hsl(31, 53%, 52%);
+ background: hsla(31, 100%, 69%, 0.45);
+ box-shadow: inset 0 1px 1px 0px rgba(255, 255, 255, 0.8),
+ inset 0 0 0 2px hsl(31, 78%, 61%),
+ inset 0 1px 0 2px hsla(31, 64%, 65%, 0.85);
}
.network-type-xhr .network-graph-bar {
- -webkit-border-image: url(Images/timelinePillYellow.png) 7 7 7 7;
+ border-color: hsl(53, 49%, 52%);
+ background: linear-gradient(0deg, hsl(53, 72%, 61%), hsl(53, 100%, 69%));
}
.network-type-xhr.resource-cached .network-graph-bar {
- -webkit-border-image: url(Images/timelineHollowPillYellow.png) 7 7 7 7;
+ border-color: hsl(53, 49%, 52%);
+ background: hsla(53, 100%, 69%, 0.85);
+ box-shadow: inset 0 1px 1px 0px rgba(255, 255, 255, 0.8),
+ inset 0 0 0 2px hsl(53, 72%, 61%),
+ inset 0 1px 0 2px hsla(54, 59%, 65%, 0.85);
}
.network-type-websocket .network-graph-bar {
- -webkit-border-image: url(Images/timelinePillGray.png) 7 7 7 7;
+ border-color: hsl(0, 0%, 65%);
+ background: linear-gradient(0deg, hsl(0, 0%, 73%), hsl(0, 0%, 78%));
}
.network-type-websocket.resource-cached .network-graph-bar {
- -webkit-border-image: url(Images/timelineHollowPillGray.png) 7 7 7 7;
+ box-shadow: inset 0 1px 1px 0px rgba(255, 255, 255, 0.8),
+ inset 0 0 0 2px hsl(0, 0%, 73%),
+ inset 0 1px 0 2px hsla(0, 0%, 76%, 0.85);
}
.network-dim-cell {

Powered by Google App Engine
This is Rietveld 408576698