Issue 99923003: Adds unit tests for swipe flick.

Issue 99923003: Adds unit tests for swipe flick. (Closed)

Created:
7 years ago by rsadam

Modified:
7 years ago

Reviewers:
kevers

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@flickv2

Visibility:
Public.

More Reviews

Description

Adds unit tests for swipe flick. We add the following tests: 1) Regular swipe flick (Should type hintText) 2) Long swipe flick (Nothing should display) 3) Composed swipe followed by flick (moveCursor triggered, but no flick) BUG=324823 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238429

Patch Set 1 : Removed extra whitespace. #

Total comments: 2

Patch Set 2 : Improved the tests and added more coverage. #

Total comments: 2

Patch Set 3 : Fixed the nit. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -2 lines)			Patch
M	chrome/test/data/chromeos/virtual_keyboard/typing_test.js	View	1	1 chunk	+102 lines, -0 lines	0 comments	Download
M	chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js	View	1 2	3 chunks	+20 lines, -0 lines	0 comments	Download
M	ui/keyboard/resources/elements/kb-keyboard.html	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kevers

https://codereview.chromium.org/99923003/diff/20001/chrome/test/data/chromeos/virtual_keyboard/typing_test.js File chrome/test/data/chromeos/virtual_keyboard/typing_test.js (right): https://codereview.chromium.org/99923003/diff/20001/chrome/test/data/chromeos/virtual_keyboard/typing_test.js#newcode340 chrome/test/data/chromeos/virtual_keyboard/typing_test.js:340: $('keyboard').updateSwipeTracker(mockEvent(0, -height/2, key)); Can you use a pointer down ...

7 years ago (2013-12-02 21:04:35 UTC) #2

rsadam

Renamed the PointerMove handler for clarity. The tests should now better mock what's actually happening. ...

7 years ago (2013-12-03 15:56:33 UTC) #3

kevers

LGTM with nit. https://codereview.chromium.org/99923003/diff/40001/chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js File chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js (right): https://codereview.chromium.org/99923003/diff/40001/chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js#newcode24 chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js:24: * @type {Enum} @enum {number}

7 years ago (2013-12-03 16:21:55 UTC) #4

rsadam

https://codereview.chromium.org/99923003/diff/40001/chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js File chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js (right): https://codereview.chromium.org/99923003/diff/40001/chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js#newcode24 chrome/test/data/chromeos/virtual_keyboard/virtual_keyboard_test_base.js:24: * @type {Enum} On 2013/12/03 16:21:55, kevers wrote: > ...

7 years ago (2013-12-03 16:23:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/99923003/60001

7 years ago (2013-12-03 16:24:04 UTC) #6

Message was sent while issue was closed.

Change committed as 238429

Expand Messages | Collapse Messages