Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 99923002: Move temp file functions to base namespace. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), weitaosu+watch_chromium.org, nkostylev+watch_chromium.org, tzik, jam, amit, browser-components-watch_chromium.org, gavinp+memory_chromium.org, dcheng, frankf, chrome-speed-team+watch_google.com, rginda+watch_chromium.org, kinuko+watch, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, kkania, joi+watch-content_chromium.org, wez+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, dcaiafa+watch_chromium.org, fischman+watch_chromium.org, sanjeevr, haitaol+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, dsinclair+watch_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, hashimoto+watch_chromium.org, Lei Zhang, tfarina, mcasas+watch_chromium.org, garykac+watch_chromium.org, tommycli, eroman, robertshield, mmenke, Greg Billock, alexeypa+watch_chromium.org, rsimha+watch_chromium.org, wjia+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move temp file functions to base namespace. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238427

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -324 lines) Patch
M apps/app_restore_service_browsertest.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M base/debug/trace_event_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.h View 1 chunk +20 lines, -20 lines 0 comments Download
M base/file_util.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M base/file_util_posix.cc View 1 4 chunks +22 lines, -22 lines 0 comments Download
M base/file_util_unittest.cc View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M base/file_util_win.cc View 1 2 3 7 chunks +22 lines, -22 lines 0 comments Download
M base/files/file_util_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/scoped_temp_dir.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M base/files/scoped_temp_dir_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M base/win/event_trace_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/shortcut_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/download_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi_worker_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/remove_stale_cache_files_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/search_metadata_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_watcher_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/resource_loader_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/syslogs_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/component_unpacker.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/test/test_installer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_creator_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_internal_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_log_uploader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/net_log_temp_file_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/fake_drive_service_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/app_indicator_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/test/upgrade_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_after_reboot_helper_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_mock_render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/session_commands.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/perf/memory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/remoting/me2me_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/convert_dict_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/pmp_column_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/crash_reporting/minidump_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/navigation_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/ui_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/common/win/install_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/print_job_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/breakpad/browser/crash_dump_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/pnacl_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/visitedlink/test/visitedlink_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/base_file_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/download/file_metadata_unittest_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/download/save_package.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/transient_file_util_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/quota_file_io_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_drag_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/npapi/plugin_stream_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac_diraccess_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/sandbox_mac_fontloading_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_widget_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_launcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M courgette/memory_allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_data_stream_unittest.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M net/base/upload_file_element_reader_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_fetcher_response_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M printing/backend/cups_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/config_file_watcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/pairing_registry_delegate_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/database/database_tracker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/database/vfs_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/blob/shareable_file_reference_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR=sky
7 years ago (2013-12-02 22:04:00 UTC) #1
brettw
7 years ago (2013-12-03 17:56:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #4 manually as r238427.

Powered by Google App Engine
This is Rietveld 408576698