Add a simple prototype "terminal" example.

Add a simple prototype "terminal" example.

(Together with an app that echoes stuff from the terminal.)

R=erg@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/a029f8f68d3487c9f6c6a187492eafc132e86367

[Elliot Glaysher, 2015-03-11 20:55:43]

I am uncomfortably excited.

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
File sky/examples/terminal/terminal.sky (right):

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
sky/examples/terminal/terminal.sky:72: }
I look...forward...to seeing how well this performs in practice.

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
sky/examples/terminal/terminal.sky:97: _control.lastChild.textContent += new
String.fromCharCode(byte);
Doesn't this mean that there's now a newline character on the start of the next
line? Not sure if you care or what the correct behaviour here is.

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
File sky/examples/terminal/terminal_file_impl.dart (right):

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
sky/examples/terminal/terminal_file_impl.dart:48: return
_display.getChar().then((c) {
If you're using async above, you might want to switch this to an await.

[viettrungluu, 2015-03-11 21:25:19]

Thanks, PTAL.

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
File sky/examples/terminal/terminal.sky (right):

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
sky/examples/terminal/terminal.sky:72: }
On 2015/03/11 20:55:43, Elliot Glaysher wrote:
> I look...forward...to seeing how well this performs in practice.

I think it already performs better than a connection over a 1200 bps modem, thus
it's good enough for me.

(Thankfully, I never had to deal with 300 bps.)

Also, by being appropriately slow, ANSI animations will be appropriately paced.

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
sky/examples/terminal/terminal.sky:97: _control.lastChild.textContent += new
String.fromCharCode(byte);
On 2015/03/11 20:55:43, Elliot Glaysher wrote:
> Doesn't this mean that there's now a newline character on the start of the
next
> line? Not sure if you care or what the correct behaviour here is.

Oops, I meant to put a return above. Fixed.

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
File sky/examples/terminal/terminal_file_impl.dart (right):

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
sky/examples/terminal/terminal_file_impl.dart:48: return
_display.getChar().then((c) {
On 2015/03/11 20:55:43, Elliot Glaysher wrote:
> If you're using async above, you might want to switch this to an await.

Done.

[Elliot Glaysher, 2015-03-11 21:29:05]

lgtm, for definitions of good which include allocating a completer for every
character.

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
File sky/examples/terminal/terminal.sky (right):

https://codereview.chromium.org/999193002/diff/1/sky/examples/terminal/termin...
sky/examples/terminal/terminal.sky:72: }
On 2015/03/11 21:25:18, viettrungluu wrote:
> On 2015/03/11 20:55:43, Elliot Glaysher wrote:
> > I look...forward...to seeing how well this performs in practice.
> 
> I think it already performs better than a connection over a 1200 bps modem,
thus
> it's good enough for me.
> 
> (Thankfully, I never had to deal with 300 bps.)
> 
> Also, by being appropriately slow, ANSI animations will be appropriately
paced.

This is not actually reassuring.

[viettrungluu, 2015-03-11 21:34:29]

Committed patchset #2 (id:20001) manually as
a029f8f68d3487c9f6c6a187492eafc132e86367 (presubmit successful).