Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 999173010: Test scanline decoding in DM. (Closed)

Created:
5 years, 9 months ago by scroggo
Modified:
5 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@scanlineDecoder3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase, just in case. #

Patch Set 3 : Fix order of output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M dm/DM.cpp View 1 3 chunks +5 lines, -3 lines 0 comments Download
M dm/DMSrcSink.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 2 3 chunks +38 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scroggo
5 years, 9 months ago (2015-03-25 19:55:55 UTC) #2
mtklein
otherwise LGTM https://codereview.chromium.org/999173010/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/999173010/diff/1/dm/DMSrcSink.cpp#newcode102 dm/DMSrcSink.cpp:102: y-1, fPath.c_str(), (int) result); y-1 and fPath.c_str() ...
5 years, 9 months ago (2015-03-25 20:31:38 UTC) #3
scroggo
https://codereview.chromium.org/999173010/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/999173010/diff/1/dm/DMSrcSink.cpp#newcode102 dm/DMSrcSink.cpp:102: y-1, fPath.c_str(), (int) result); On 2015/03/25 20:31:38, mtklein wrote: ...
5 years, 9 months ago (2015-03-25 20:36:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999173010/40001
5 years, 9 months ago (2015-03-25 20:36:44 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 20:48:53 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9c59ebc0db7cade1537591813430f7be47123e76

Powered by Google App Engine
This is Rietveld 408576698