Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 999173007: Make compiler more acceptive wrt Isolate::use_crankshaft. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make compiler more acceptive wrt Isolate::use_crankshaft. This allows using %OptimizeFunctionOnNextCall and friends even when Crankshaft is disabled. Note that this should only affect code paths that are not relevant to performance. By now we have a single bailout point in place within OptimizedCompileJob::CreateGraph that ensures Crankshaft is only used when enabled and supported. R=titzer@chromium.org Committed: https://crrev.com/d6085f277c7ea2940a7638375ae07ea4c167ab81 Cr-Commit-Position: refs/heads/master@{#27367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M src/factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-23 14:09:56 UTC) #1
titzer
On 2015/03/23 14:09:56, Michael Starzinger wrote: LGTM YUMM
5 years, 9 months ago (2015-03-23 14:13:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/999173007/1
5 years, 9 months ago (2015-03-23 14:18:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 14:25:50 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 14:25:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6085f277c7ea2940a7638375ae07ea4c167ab81
Cr-Commit-Position: refs/heads/master@{#27367}

Powered by Google App Engine
This is Rietveld 408576698