Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4277)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.h

Issue 99913004: Add error handling to inline signin flow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: roger's comments fixed Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_helper.h
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.h b/chrome/browser/ui/sync/one_click_signin_helper.h
index 2c0b09dcdc71b4b3c5aa04d3fa900a3a23dfd1c5..8ae4440068d9189aa45f26fc75b428e11d2e4eb3 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.h
+++ b/chrome/browser/ui/sync/one_click_signin_helper.h
@@ -120,6 +120,13 @@ class OneClickSigninHelper
int child_id,
int route_id);
+ // If the |source| is not settings page/webstore, redirects to
+ // the NTP/Apps page.
+ static void RedirectToNtpOrAppsPageIfNecessary(
+ content::WebContents* contents, signin::Source source);
+
+ static void ShowSigninErrorBubble(Browser* browser, const std::string& error);
+
// Remove the item currently at the top of the history list if it's
// the Gaia redirect URL. Due to limitations of the NavigationController
// this cannot be done until a new page becomes "current".
@@ -208,7 +215,6 @@ class OneClickSigninHelper
int route_id);
void RedirectToSignin();
- void ShowSigninErrorBubble(Browser* browser, const std::string& error);
// Clear all data member of the helper, except for the error.
void CleanTransientState();
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698