Issue 99913004: Add error handling to inline signin flow

Issue 99913004: Add error handling to inline signin flow (Closed)

Created:
7 years ago by guohui

Modified:
7 years ago

Reviewers:
Roger Tawa OOO till Jul 10th, sky

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, rsimha+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add error handling to inline signin flow BUG=318859 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238439

Patch Set 2 : roger's comments fixed #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -34 lines)			Patch
M	chrome/browser/ui/sync/one_click_signin_helper.h	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	1	4 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/inline_login_ui.cc	View	1	8 chunks	+22 lines, -20 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

lgtm https://codereview.chromium.org/99913004/diff/20001/chrome/browser/ui/webui/inline_login_ui.cc File chrome/browser/ui/webui/inline_login_ui.cc (right): https://codereview.chromium.org/99913004/diff/20001/chrome/browser/ui/webui/inline_login_ui.cc#newcode321 chrome/browser/ui/webui/inline_login_ui.cc:321: } Should reuse function from OneClickSigninHelper, like you ...

7 years ago (2013-12-02 21:04:51 UTC) #2

guohui

On 2013/12/02 21:04:51, Roger Tawa wrote: > lgtm > > https://codereview.chromium.org/99913004/diff/20001/chrome/browser/ui/webui/inline_login_ui.cc > File chrome/browser/ui/webui/inline_login_ui.cc (right): ...

7 years ago (2013-12-02 22:19:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/99913004/30004

7 years ago (2013-12-03 16:51:29 UTC) #6

Message was sent while issue was closed.

Change committed as 238439

Expand Messages | Collapse Messages