Issue 99913002: Remove "ScopedHandleBase<H>::operator H() const"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99913002: Remove "ScopedHandleBase<H>::operator H() const" (Closed)

Created:
7 years ago by darin (slow to review)

Modified:
7 years ago

Reviewers:
viettrungluu

CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove "ScopedHandleBase<H>::operator H() const" Reason: it is too easy to misuse this and end up leaking a handle. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238252

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -52 lines)			Patch
M	mojo/common/handle_watcher_unittest.cc	View	9 chunks	+22 lines, -22 lines	0 comments	Download
M	mojo/common/message_pump_mojo.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/public/bindings/lib/connector.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	mojo/public/system/core_cpp.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/public/tests/system_core_cpp_unittest.cc	View	12 chunks	+25 lines, -21 lines	0 comments	Download

Total messages: 3 (0 generated)

darin (slow to review)

7 years ago (2013-12-03 00:54:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r238252 (presubmit successful).