components/password_manager/core/browser/affiliated_match_helper.cc - Issue 999073002: Integrate serving affiliation-based matches into the PasswordStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliated_match_helper.cc

Issue 999073002: Integrate serving affiliation-based matches into the PasswordStore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aff_integration

Patch Set: Reduce scope of CL, test utils are fixed in a separate CL. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/affiliated_match_helper.h ('k') | components/password_manager/core/browser/password_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/affiliated_match_helper.cc

diff --git a/components/password_manager/core/browser/affiliated_match_helper.cc b/components/password_manager/core/browser/affiliated_match_helper.cc

index f6b051f8d25c42f35263d43ddf3a3978e8759ade..529eda4aa9f1d4bdce90fbd2318d5b0f3bc6a7c4 100644

--- a/components/password_manager/core/browser/affiliated_match_helper.cc

+++ b/components/password_manager/core/browser/affiliated_match_helper.cc

@@ -39,15 +39,16 @@ AffiliatedMatchHelper::AffiliatedMatchHelper(

task_runner_for_waiting_(base::ThreadTaskRunnerHandle::Get()),

affiliation_service_(affiliation_service.Pass()),

weak_ptr_factory_(this) {

- DCHECK(affiliation_service_);

- DCHECK(password_store_);

}

AffiliatedMatchHelper::~AffiliatedMatchHelper() {

- password_store_->RemoveObserver(this);

+ if (password_store_)

+ password_store_->RemoveObserver(this);

}

void AffiliatedMatchHelper::Initialize() {

+ DCHECK(password_store_);

+ DCHECK(affiliation_service_);

task_runner_for_waiting_->PostDelayedTask(

FROM_HERE, base::Bind(&AffiliatedMatchHelper::DoDeferredInitialization,

weak_ptr_factory_.GetWeakPtr()),