Remove uses of KillProcess()

content/plugin/plugin_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/plugin/plugin_thread.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_MACOSX)
 #include <CoreFoundation/CoreFoundation.h>
 #endif
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
-#include "base/process/kill.h"
-#include "base/process/process_handle.h"
+#include "base/process/process.h"
 #include "base/threading/thread_local.h"
 #include "content/child/blink_platform_impl.h"
 #include "content/child/child_process.h"
 #include "content/child/npapi/npobject_util.h"
 #include "content/child/npapi/plugin_lib.h"
 #include "content/common/plugin_process_messages.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/plugin/content_plugin_client.h"
 #include "third_party/WebKit/public/web/WebKit.h"
 #include "ipc/ipc_channel_handle.h"
@@ skipping 19 matching lines @@
     // as the browser does not terminate plugin processes on shutdown.
     // We achieve this by posting an exit process task on the IO thread.
     base::MessageLoop::current()->PostDelayedTask(
         FROM_HERE,
         base::Bind(&EnsureTerminateMessageFilter::Terminate, this),
         kPluginProcessTerminateTimeout);
   }
 
  private:
   void Terminate() {
-    base::KillProcess(base::GetCurrentProcessHandle(), 0, false);
+    base::Process::Current().Terminate(0, false);
   }
 };
 
 }  // namespace
 
 static base::LazyInstance<base::ThreadLocalPointer<PluginThread> > lazy_tls =
     LAZY_INSTANCE_INITIALIZER;
 
 PluginThread::PluginThread()
     : preloaded_plugin_module_(NULL),
@@ skipping 38 matching lines @@
   ChildThreadImpl::Shutdown();
 
   if (preloaded_plugin_module_) {
     base::UnloadNativeLibrary(preloaded_plugin_module_);
     preloaded_plugin_module_ = NULL;
   }
   NPChannelBase::CleanupChannels();
   PluginLib::UnloadAllPlugins();
 
   if (forcefully_terminate_plugin_process_)
-    base::KillProcess(base::GetCurrentProcessHandle(), 0, /* wait= */ false);
+    base::Process::Current().Terminate(0, /* wait= */ false);
 

[cpu_(ooo_6.6-7.5), 2015/03/17 20:36:31]

this code review is a good example of why bool parameters are harmful.

   lazy_tls.Pointer()->Set(NULL);
 }
 
 PluginThread* PluginThread::current() {
   return lazy_tls.Pointer()->Get();
 }
 
 bool PluginThread::OnControlMessageReceived(const IPC::Message& msg) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PluginThread, msg)
@@ skipping 21 matching lines @@
   }
 
   Send(new PluginProcessHostMsg_ChannelCreated(channel_handle));
 }
 
 void PluginThread::OnNotifyRenderersOfPendingShutdown() {
   PluginChannel::NotifyRenderersOfPendingShutdown();
 }
 
 }  // namespace content