Remove uses of KillProcess()

content/child/child_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/child_thread_impl.h"
 
 #include <signal.h>
 
 #include <string>
 
 #include "base/allocator/allocator_extension.h"
 #include "base/base_switches.h"
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/debug/leak_annotations.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/timer_slack.h"
 #include "base/metrics/field_trial.h"
-#include "base/process/kill.h"
+#include "base/process/process.h"
 #include "base/process/process_handle.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/synchronization/condition_variable.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread_local.h"
 #include "base/tracked_objects.h"
 #include "components/tracing/child_trace_message_filter.h"
 #include "content/child/bluetooth/bluetooth_message_filter.h"
 #include "content/child/child_discardable_shared_memory_manager.h"
@@ skipping 674 matching lines @@
   // where we send out an initial feeler request to the child process host
   // instance in the browser to verify if it's ok to shutdown the child process.
   // The browser then sends back a response if it's ok to shutdown. This avoids
   // race conditions if the process refcount is 0 but there's an IPC message
   // inflight that would addref it.
   Send(new ChildProcessHostMsg_ShutdownRequest);
 }
 
 void ChildThreadImpl::EnsureConnected() {
   VLOG(0) << "ChildThreadImpl::EnsureConnected()";
-  base::KillProcess(base::GetCurrentProcessHandle(), 0, false);
+  base::Process::Current().Terminate(0, false);
 }
 

[cpu_(ooo_6.6-7.5), 2015/03/17 20:36:31]

ensure connected --> kills
ensure dead --> connects ?

[rvargas (doing something else), 2015/03/17 22:40:53]

That sounds reasonable!.

(I don't really know what this code is doing... it is called through a
PostDelayedTask from Init... looks like if a timeout hits we just give up on
living)

(will rename to anything you want me to).

 void ChildThreadImpl::OnProcessBackgrounded(bool background) {
   // Set timer slack to maximum on main thread when in background.
   base::TimerSlack timer_slack = base::TIMER_SLACK_NONE;
   if (background)
     timer_slack = base::TIMER_SLACK_MAXIMUM;
   base::MessageLoop::current()->SetTimerSlack(timer_slack);
 
 #ifdef OS_WIN
   // Windows Vista+ has a fancy process backgrounding mode that can only be set
   // from within the process. This used to be how chrome set its renderers into
   // background mode on Windows but was removed due to http://crbug.com/398103.
   // As we experiment with bringing back some other form of background mode for
   // hidden renderers, add a bucket to allow us to trigger this undesired method
   // of setting background state in order to confirm that the metrics which were
   // added to prevent regressions on the aforementioned issue indeed catch such
   // regressions and are thus a reliable way to confirm that our latest proposal
   // doesn't cause such issues. TODO(gab): Remove this once the experiment is
   // over (http://crbug.com/458594).
   base::FieldTrial* trial =
       base::FieldTrialList::Find("BackgroundRendererProcesses");
   if (trial && trial->group_name() == "AllowBackgroundModeFromRenderer")
     base::Process::Current().SetProcessBackgrounded(background);
 #endif  // OS_WIN
 }
 
 }  // namespace content