Source/web/WebLocalFrameImpl.cpp - Issue 999033002: Advance document lifecycle to CompositingClean prior to hit testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 999033002: Advance document lifecycle to CompositingClean prior to hit testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix webkit_unit_tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 27e87b7c9cf9ec7a98cfa0b16bda313a0f96ed76..25f9f9d640cd46be1af48b391e32dbb50597bb47 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -1302,7 +1302,7 @@ VisiblePosition WebLocalFrameImpl::visiblePositionForWindowPoint(const WebPoint&

HitTestRequest request = HitTestRequest::Move | HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping;

HitTestResult result(frame()->view()->windowToContents(roundedIntPoint(unscaledPoint)));

- frame()->document()->layoutView()->layer()->hitTest(request, result);

+ frame()->document()->layoutView()->hitTest(request, result);

qiankun 2015/03/20 07:50:22 Also advance to CompositingClean state here.

if (Node* node = result.innerNode())

return frame()->selection().selection().visiblePositionRespectingEditingBoundary(result.localPoint(), node);

« no previous file with comments | « Source/core/paint/DeprecatedPaintLayer.cpp ('k') | no next file » | no next file with comments »