Source/web/WebLocalFrameImpl.cpp - Issue 999033002: Advance document lifecycle to CompositingClean prior to hit testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 999033002: Advance document lifecycle to CompositingClean prior to hit testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index c4e2a58fb8750de253e6424681f1b72fd974c613..363ecc32f89e861096e465f995bc7b9e867e33a7 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -1298,7 +1298,7 @@ VisiblePosition WebLocalFrameImpl::visiblePositionForViewportPoint(const WebPoin

{

HitTestRequest request = HitTestRequest::Move | HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping;

HitTestResult result(frame()->view()->viewportToContents(pointInViewport));

- frame()->document()->layoutView()->layer()->hitTest(request, result);

+ frame()->document()->layoutView()->hitTest(request, result);

if (Node* node = result.innerNode())

return frame()->selection().selection().visiblePositionRespectingEditingBoundary(result.localPoint(), node);

« Source/core/dom/DocumentLifecycle.cpp ('K') | « Source/core/paint/DeprecatedPaintLayer.cpp ('k') | no next file » | no next file with comments »