Allowing V8ObjectStatsMetric users to specify metrics to capture.

Allowing V8ObjectStatsMetric users to specify metrics to capture.

V8ObjectStatsMetric would previously capture all V8 statistics.
Added a constructor parameter so that users could capture a subset
of the V8 statistics if desired. Default is as before: capture them
all.

Making this change so that the IndexedDB perf tests (indexeddb_perf)
can be modified to report only a few metrics to simplify the test
results.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243394

[cmumford, 2014-01-02 23:01:00]

Hi Ross:

Here's the change (finally!). I've tested it with another change (123553003).

[rmcilroy, 2014-01-03 09:58:28]

lgtm with one nit. You'll need to get an lgtm from an owner though.

https://codereview.chromium.org/99903009/diff/1/tools/perf/metrics/v8_object_...
File tools/perf/metrics/v8_object_stats.py (right):

https://codereview.chromium.org/99903009/diff/1/tools/perf/metrics/v8_object_...
tools/perf/metrics/v8_object_stats.py:183: counters = counters or _COUNTER_NAMES
nit - drop the default argument, and "counters = counters or _COUNTER_NAMES"
line from here please.

[cmumford, 2014-01-03 17:59:43]

Adding owner Marja. I didn't want to change the contract of GetV8StatsTable
(which is used in one other file), but if you think I should implement Ross' nit
please let me know.

[rmcilroy, 2014-01-03 18:05:09]

On 2014/01/03 17:59:43, cmumford wrote:
> Adding owner Marja. I didn't want to change the contract of GetV8StatsTable
> (which is used in one other file), but if you think I should implement Ross'
nit
> please let me know.

The only other user of GetV8StatsTable (endure.py) passes an explicit argument
for counters (and the argument was only added for them in the first place), so I
think it's OK to remove the default value from this argument since it won't
change things for them (note, I only want the default value and subsequent line
to be removed, not the argument itself).

[cmumford, 2014-01-03 18:36:43]

Removed default counters value.

[rmcilroy, 2014-01-06 11:34:32]

Thanks Chris.

lgtm

[marja, 2014-01-07 11:22:45]

lgtm (owner rubberstamp, the change seems trivial)

[commit-bot: I haz the power, 2014-01-07 18:53:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cmumford@chromium.org/99903009/70001

[commit-bot: I haz the power, 2014-01-07 21:51:48]

Change committed as 243394