Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 99903006: Revert "See also webkit.org/b/113415" (Closed)

Created:
7 years ago by adamk
Modified:
7 years ago
Reviewers:
rhogan, ojan
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), zoltan1, eae+blinkwatch, leviw+renderwatch, dstockwell, Timothy Loh, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Revert "See also webkit.org/b/113415" This reverts commit 4a9f9ac3a1106f937d36f9322bb52da903ca60a6. That patch broke a bunch of layout tests on Mac, many of them the particular ones for which it provided expectations. I'm guessing the right thing is to reland with [ NeedsRebaseline ] lines in TestExpectations and let the auto-rebaseline bot do the job. BUG=320743 TBR=ojan@chromium.org,robhogan@gmail.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -2040 lines) Patch
D LayoutTests/compositing/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 1 chunk +0 lines, -75 lines 0 comments Download
M LayoutTests/compositing/overflow/opt-in-all-layers-after-unclipped-descendant-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/css2.1/20110323/abspos-containing-block-initial-001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/block/inflow-bottom-margin.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/block/inflow-bottom-margin-expected.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/block/positioned-bottom-margin.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/block/positioned-bottom-margin-expected.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/borders/border-image-rotate-transform-expected.png View Binary file 0 comments Download
D LayoutTests/fast/borders/border-image-scale-transform-expected.png View Binary file 0 comments Download
D LayoutTests/fast/forms/form-hides-table-expected.png View Binary file 0 comments Download
D LayoutTests/fast/forms/form-hides-table-expected.txt View 1 chunk +0 lines, -169 lines 0 comments Download
M LayoutTests/platform/linux/fast/borders/border-image-rotate-transform-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/borders/border-image-scale-transform-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/forms/form-hides-table-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/custom/altglyph-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/text/multichar-glyph-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/transforms/animated-path-inside-transformed-html-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac-lion/css2.1/20110323/abspos-containing-block-initial-001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac-lion/fast/borders/border-image-rotate-transform-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/fast/borders/border-image-rotate-transform-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac-lion/fast/borders/border-image-scale-transform-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/fast/borders/border-image-scale-transform-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/platform/mac-snowleopard/compositing/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/compositing/overflow/opt-in-all-layers-after-unclipped-descendant-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/platform/mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-snowleopard/fast/borders/border-image-rotate-transform-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/platform/mac-snowleopard/fast/borders/border-image-scale-transform-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-snowleopard/fast/borders/border-image-scale-transform-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/fast/forms/form-hides-table-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/forms/form-hides-table-expected.txt View 1 chunk +0 lines, -169 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/svg/custom/altglyph-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/svg/custom/altglyph-expected.txt View 1 chunk +0 lines, -185 lines 0 comments Download
D LayoutTests/platform/mac-snowleopard/svg/custom/multichar-glyph-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/svg/custom/multichar-glyph-expected.txt View 1 chunk +0 lines, -182 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/svg/text/multichar-glyph-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/svg/text/multichar-glyph-expected.txt View 1 chunk +0 lines, -182 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt View 1 chunk +0 lines, -177 lines 0 comments Download
A + LayoutTests/platform/mac-snowleopard/virtual/gpu/compositedscrolling/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac-snowleopard/virtual/gpu/compositedscrolling/overflow/opt-in-all-layers-after-unclipped-descendant-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/platform/mac/compositing/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/compositing/overflow/opt-in-all-layers-after-unclipped-descendant-expected.txt View 3 chunks +3 lines, -5 lines 0 comments Download
A LayoutTests/platform/mac/fast/borders/border-image-rotate-transform-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac/fast/borders/border-image-scale-transform-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac/fast/forms/form-hides-table-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/mac/svg/custom/altglyph-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/svg/custom/altglyph-expected.txt View 1 chunk +0 lines, -185 lines 0 comments Download
D LayoutTests/platform/mac/svg/custom/multichar-glyph-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/svg/custom/multichar-glyph-expected.txt View 1 chunk +0 lines, -182 lines 0 comments Download
M LayoutTests/platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
A + LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/platform/mac/virtual/gpu/compositedscrolling/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/gpu/compositedscrolling/overflow/opt-in-all-layers-after-unclipped-descendant-expected.txt View 3 chunks +3 lines, -5 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/softwarecompositing/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win/compositing/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win/compositing/tiling/tile-cache-zoomed-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M LayoutTests/platform/win/fast/borders/border-image-rotate-transform-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/borders/border-image-rotate-transform-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/borders/border-image-scale-transform-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/borders/border-image-scale-transform-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/form-hides-table-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/forms/form-hides-table-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/altglyph-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/svg/custom/altglyph-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/svg/text/multichar-glyph-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/svg/text/multichar-glyph-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/svg/transforms/animated-path-inside-transformed-html-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/svg/transforms/animated-path-inside-transformed-html-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/virtual/gpu/compositedscrolling/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/virtual/softwarecompositing/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/platform/win/virtual/softwarecompositing/tiling/tile-cache-zoomed-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png View Binary file 0 comments Download
D LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt View 1 chunk +0 lines, -177 lines 0 comments Download
D LayoutTests/virtual/gpu/compositedscrolling/overflow/opt-in-all-layers-after-unclipped-descendant-expected.txt View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/virtual/softwarecompositing/overflow/do-not-opt-non-stacking-context-descendants-into-composited-scrolling-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
adamk
7 years ago (2013-12-12 00:38:28 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r163739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698