Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chromeos/dbus/nfc_property_set.h

Issue 99903003: nfc: Various fixes to the NFC D-Bus client in chromeos/dbus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed clang error. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/nfc_device_client.cc ('k') | chromeos/dbus/nfc_property_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/nfc_property_set.h
diff --git a/chromeos/dbus/nfc_property_set.h b/chromeos/dbus/nfc_property_set.h
index 6560d4d6ab478730719189ceba86a3b6fc407f55..6b02ea0af593a6436d7543acb7977dfb01059eae 100644
--- a/chromeos/dbus/nfc_property_set.h
+++ b/chromeos/dbus/nfc_property_set.h
@@ -7,6 +7,7 @@
#include <string>
+#include "base/callback.h"
#include "dbus/message.h"
#include "dbus/object_proxy.h"
#include "dbus/property.h"
@@ -23,16 +24,29 @@ class NfcPropertySet : public dbus::PropertySet {
const std::string& interface,
const PropertyChangedCallback& callback);
+ // Destructor; we don't hold on to any references or memory that needs
+ // explicit clean-up, but clang thinks we might.
+ virtual ~NfcPropertySet();
+
+ // Caches |callback| so that it will be invoked after a call to GetAll()
+ // has successfully received all existing properties from the remote object.
+ void SetAllPropertiesReceivedCallback(const base::Closure& callback);
+
// dbus::PropertySet overrides
virtual void ConnectSignals() OVERRIDE;
virtual void Get(dbus::PropertyBase* property,
GetCallback callback) OVERRIDE;
virtual void GetAll() OVERRIDE;
+ virtual void OnGetAll(dbus::Response* response) OVERRIDE;
virtual void Set(dbus::PropertyBase* property,
SetCallback callback) OVERRIDE;
virtual void ChangedReceived(dbus::Signal* signal) OVERRIDE;
private:
+ // Optional callback used to notify clients when all properties were received
+ // after a call to GetAll.
+ base::Closure on_get_all_callback_;
+
DISALLOW_COPY_AND_ASSIGN(NfcPropertySet);
};
« no previous file with comments | « chromeos/dbus/nfc_device_client.cc ('k') | chromeos/dbus/nfc_property_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698