nfc: Various fixes to the NFC D-Bus client in chromeos/dbus.

nfc: Various fixes to the NFC D-Bus client in chromeos/dbus.

This CL applies the following fixes:

  1. Fixed a bug in chromeos::NfcPropertySet::Set where the code didn't pass
     in the property name and value to the D-Bus call.
  2. Changed NfcTagClient::Write and NfcDeviceClient::Push to take in a
     base::DictionaryValue instead of a map of strings for the NDEF attributes,
     as the NDEF record attributes don't have string as their only possible
     value type.
  3. Fixed a regression in DBusThreadManager due to recent refactors that broke
     the NFC client initialization code.
  4. Allow users of NfcPropertySet to be notified when a call to GetAll completes.

BUG=316471
TEST=chromeos_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238604

[keybuk, 2013-12-03 18:13:26]

https://codereview.chromium.org/99903003/diff/1/chromeos/dbus/dbus_thread_man...
File chromeos/dbus/dbus_thread_manager.cc (right):

https://codereview.chromium.org/99903003/diff/1/chromeos/dbus/dbus_thread_man...
chromeos/dbus/dbus_thread_manager.cc:435:
InitClient(g_dbus_thread_manager->GetNfcManagerClient());
These should be in alphabetical order.

If there's a dependency reason for them being out of order, you should explain
it in the comment above (e.g. "adapter client uses manager client during
initialization") so that somebody doesn't accidentally fix this in future

[armansito, 2013-12-03 18:34:19]

https://codereview.chromium.org/99903003/diff/1/chromeos/dbus/dbus_thread_man...
File chromeos/dbus/dbus_thread_manager.cc (right):

https://codereview.chromium.org/99903003/diff/1/chromeos/dbus/dbus_thread_man...
chromeos/dbus/dbus_thread_manager.cc:435:
InitClient(g_dbus_thread_manager->GetNfcManagerClient());
On 2013/12/03 18:13:26, keybuk wrote:
> These should be in alphabetical order.
> 
> If there's a dependency reason for them being out of order, you should explain
> it in the comment above (e.g. "adapter client uses manager client during
> initialization") so that somebody doesn't accidentally fix this in future

There is a dependency reason and the comment line above that says "Initialize
NFC clients in the correct order" exists to clarify that, though somebody DID
accidentally fix this despite the comment and you didn't spot it either, so I
suppose this is not clear enough. So I moved the NFC client initialization after
the standard list of inits, with spaces around it.

[keybuk, 2013-12-03 18:44:11]

lgtm

[commit-bot: I haz the power, 2013-12-03 23:51:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/99903003/60001

[commit-bot: I haz the power, 2013-12-04 00:27:57]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[armansito, 2013-12-04 00:29:43]

stevenjb@, PTAL & rubber-stamp.

[stevenjb, 2013-12-04 00:32:21]

rubberstamp lgtm

[commit-bot: I haz the power, 2013-12-04 01:12:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/99903003/60001

[commit-bot: I haz the power, 2013-12-04 06:27:15]

Change committed as 238604