content/common/presentation/presentation_service.mojom - Issue 999003004: Implementing closeSession from WebPresentationClient to PresentationService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/presentation/presentation_service.mojom

Issue 999003004: Implementing closeSession from WebPresentationClient to PresentationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/presentation/presentation_service_impl.cc ('k') | content/renderer/presentation/presentation_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/presentation/presentation_service.mojom

diff --git a/content/common/presentation/presentation_service.mojom b/content/common/presentation/presentation_service.mojom

index e672ad14ad6b5e821b27d9aec5e18b066538ced8..fad05397f9cbeb6f57e0e99e3e2037019cae32ce 100644

--- a/content/common/presentation/presentation_service.mojom

+++ b/content/common/presentation/presentation_service.mojom

@@ -71,4 +71,7 @@ interface PresentationService {

// silently and without user action.

JoinSession(string presentation_url, string? presentation_id)

=> (PresentationSessionInfo? sessionInfo, PresentationError? error);

-};

+ // Called when closeSession() is called by the frame.

+ CloseSession(string presentation_url, string? presentation_id);

whywhat 2015/03/19 01:05:27 I don't think the id is optional here. It will be

haibinlu 2015/03/19 01:15:37 Right, it should not be optional. Updated.

+};