chrome/common/safe_browsing/binary_feature_extractor_posix.cc - Issue 999003003: Include attributes of zipped binaries in ClientDownloadRequests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/binary_feature_extractor_posix.cc

Issue 999003003: Include attributes of zipped binaries in ClientDownloadRequests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zip2

Patch Set: fix ordering of SandboxedZipAnalyzer methods Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc ('K') | « chrome/common/safe_browsing/binary_feature_extractor.h ('k') | chrome/common/safe_browsing/binary_feature_extractor_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/safe_browsing/binary_feature_extractor_posix.cc

diff --git a/chrome/common/safe_browsing/binary_feature_extractor_posix.cc b/chrome/common/safe_browsing/binary_feature_extractor_posix.cc

index 265fcfed2de6826d61d0763083a91c0a7613311d..2e6ccba5c15f8a62e0b99eadd8db6c391a9110bf 100644

--- a/chrome/common/safe_browsing/binary_feature_extractor_posix.cc

+++ b/chrome/common/safe_browsing/binary_feature_extractor_posix.cc

@@ -24,4 +24,11 @@ bool BinaryFeatureExtractor::ExtractImageHeaders(

return false;

}

+bool BinaryFeatureExtractor::ExtractImageHeadersFromFile(

+ base::File file,

+ ExtractHeadersOption options,

+ ClientDownloadRequest_ImageHeaders* image_headers) {

+ return false;

} // namespace safe_browsing