chrome/common/safe_browsing/csd.proto - Issue 999003003: Include attributes of zipped binaries in ClientDownloadRequests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 999003003: Include attributes of zipped binaries in ClientDownloadRequests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zip2

Patch Set: pull out results Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/sandboxed_zip_analyzer_unittest.cc ('K') | « chrome/common/safe_browsing/binary_feature_extractor_win.cc ('k') | chrome/common/safe_browsing/zip_analyzer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/safe_browsing/csd.proto

diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto

index cf487918fdfe4e0d7249bcbfc6a9fc84decbeea4..ae0e7b906ae3c156e6b3bf64d0fe80e2ab99f6f2 100644

--- a/chrome/common/safe_browsing/csd.proto

+++ b/chrome/common/safe_browsing/csd.proto

@@ -256,6 +256,21 @@ message ClientDownloadRequest {

// client.

optional ImageHeaders image_headers = 18;

+ // Fields 19-21 are reserved for server-side use and are never sent by the

+ // client.

+ // A binary contained in an archive (e.g., a .zip archive).

+ message ArchivedBinary {

+ optional string file_basename = 1;

+ optional DownloadType download_type = 2;

+ optional Digests digests = 3;

+ optional int64 length = 4;

+ optional SignatureInfo signature = 5;

+ optional ImageHeaders image_headers = 6;

+ }

+ repeated ArchivedBinary archived_binary = 22;

}

message ClientDownloadResponse {