pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart - Issue 998983002: Ensure that descriptors have a prototype.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 998983002: Ensure that descriptors have a prototype. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Added missing test. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

index ce3e760d3db6a388b64dea8705616005e28b727c..7d91c87cacbe50f461eac763f793a025b9e2730a 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

@@ -476,6 +476,9 @@ class OldEmitter implements Emitter {

var members = Object.keys(properties);

for (var i = 0; i < members.length; i++) {

var member = members[i];

+ if (!Object.hasOwnProperty.call(properties, member)) {

floitsch 2015/03/11 13:11:49 This should not be necessary (and always be false)

herhut 2015/03/11 13:36:24 Done.

+ continue;

+ }

object[member] = properties[member];

}

// Use a function for `true` here, as functions are stored in the

« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart » ('j') | no next file with comments »