pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart - Issue 998983002: Ensure that descriptors have a prototype.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

Issue 998983002: Ensure that descriptors have a prototype. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

index 5981370a47a9b5d75f139a2c9ae161a17a261d22..86a9cbaf775a10877bdd728ff330380a39ec4fec 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

@@ -55,7 +55,8 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,

jsAst.Statement processClassData = js.statement('''{

function processClassData(cls, descriptor, processedClasses) {

- var newDesc = map(); // Use a slow object.

+ var newDesc = {};

floitsch 2015/03/11 13:11:49 comment why not map().

herhut 2015/03/11 13:36:24 Done.

+ newDesc.x = 0; delete newDesc.x; // Make object slow.

var previousProperty;

var properties = Object.keys(descriptor);

for (var i = 0; i < properties.length; i++) {

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | no next file » | no next file with comments »