Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: src/serialize.cc

Issue 998943003: Simplify pending message object handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/base/platform/platform.h" 9 #include "src/base/platform/platform.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 "std::log"); 95 "std::log");
96 Add(ExternalReference::store_buffer_top(isolate).address(), 96 Add(ExternalReference::store_buffer_top(isolate).address(),
97 "store_buffer_top"); 97 "store_buffer_top");
98 Add(ExternalReference::address_of_the_hole_nan().address(), "the_hole_nan"); 98 Add(ExternalReference::address_of_the_hole_nan().address(), "the_hole_nan");
99 Add(ExternalReference::get_date_field_function(isolate).address(), 99 Add(ExternalReference::get_date_field_function(isolate).address(),
100 "JSDate::GetField"); 100 "JSDate::GetField");
101 Add(ExternalReference::date_cache_stamp(isolate).address(), 101 Add(ExternalReference::date_cache_stamp(isolate).address(),
102 "date_cache_stamp"); 102 "date_cache_stamp");
103 Add(ExternalReference::address_of_pending_message_obj(isolate).address(), 103 Add(ExternalReference::address_of_pending_message_obj(isolate).address(),
104 "address_of_pending_message_obj"); 104 "address_of_pending_message_obj");
105 Add(ExternalReference::address_of_has_pending_message(isolate).address(),
106 "address_of_has_pending_message");
107 Add(ExternalReference::get_make_code_young_function(isolate).address(), 105 Add(ExternalReference::get_make_code_young_function(isolate).address(),
108 "Code::MakeCodeYoung"); 106 "Code::MakeCodeYoung");
109 Add(ExternalReference::cpu_features().address(), "cpu_features"); 107 Add(ExternalReference::cpu_features().address(), "cpu_features");
110 Add(ExternalReference::old_pointer_space_allocation_top_address(isolate) 108 Add(ExternalReference::old_pointer_space_allocation_top_address(isolate)
111 .address(), 109 .address(),
112 "Heap::OldPointerSpaceAllocationTopAddress"); 110 "Heap::OldPointerSpaceAllocationTopAddress");
113 Add(ExternalReference::old_pointer_space_allocation_limit_address(isolate) 111 Add(ExternalReference::old_pointer_space_allocation_limit_address(isolate)
114 .address(), 112 .address(),
115 "Heap::OldPointerSpaceAllocationLimitAddress"); 113 "Heap::OldPointerSpaceAllocationLimitAddress");
116 Add(ExternalReference::old_data_space_allocation_top_address(isolate) 114 Add(ExternalReference::old_data_space_allocation_top_address(isolate)
(...skipping 2443 matching lines...) Expand 10 before | Expand all | Expand 10 after
2560 DisallowHeapAllocation no_gc; 2558 DisallowHeapAllocation no_gc;
2561 SerializedCodeData* scd = new SerializedCodeData(cached_data); 2559 SerializedCodeData* scd = new SerializedCodeData(cached_data);
2562 SanityCheckResult r = scd->SanityCheck(isolate, source); 2560 SanityCheckResult r = scd->SanityCheck(isolate, source);
2563 if (r == CHECK_SUCCESS) return scd; 2561 if (r == CHECK_SUCCESS) return scd;
2564 cached_data->Reject(); 2562 cached_data->Reject();
2565 source->GetIsolate()->counters()->code_cache_reject_reason()->AddSample(r); 2563 source->GetIsolate()->counters()->code_cache_reject_reason()->AddSample(r);
2566 delete scd; 2564 delete scd;
2567 return NULL; 2565 return NULL;
2568 } 2566 }
2569 } } // namespace v8::internal 2567 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698