Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 998943003: Simplify pending message object handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen.h ('k') | src/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5234 matching lines...) Expand 10 before | Expand all | Expand 10 after
5245 __ push(edx); 5245 __ push(edx);
5246 5246
5247 // Store result register while executing finally block. 5247 // Store result register while executing finally block.
5248 __ push(result_register()); 5248 __ push(result_register());
5249 5249
5250 // Store pending message while executing finally block. 5250 // Store pending message while executing finally block.
5251 ExternalReference pending_message_obj = 5251 ExternalReference pending_message_obj =
5252 ExternalReference::address_of_pending_message_obj(isolate()); 5252 ExternalReference::address_of_pending_message_obj(isolate());
5253 __ mov(edx, Operand::StaticVariable(pending_message_obj)); 5253 __ mov(edx, Operand::StaticVariable(pending_message_obj));
5254 __ push(edx); 5254 __ push(edx);
5255
5256 ExternalReference has_pending_message =
5257 ExternalReference::address_of_has_pending_message(isolate());
5258 __ mov(edx, Operand::StaticVariable(has_pending_message));
5259 __ SmiTag(edx);
5260 __ push(edx);
5261 } 5255 }
5262 5256
5263 5257
5264 void FullCodeGenerator::ExitFinallyBlock() { 5258 void FullCodeGenerator::ExitFinallyBlock() {
5265 DCHECK(!result_register().is(edx)); 5259 DCHECK(!result_register().is(edx));
5266 // Restore pending message from stack. 5260 // Restore pending message from stack.
5267 __ pop(edx); 5261 __ pop(edx);
5268 __ SmiUntag(edx);
5269 ExternalReference has_pending_message =
5270 ExternalReference::address_of_has_pending_message(isolate());
5271 __ mov(Operand::StaticVariable(has_pending_message), edx);
5272
5273 __ pop(edx);
5274 ExternalReference pending_message_obj = 5262 ExternalReference pending_message_obj =
5275 ExternalReference::address_of_pending_message_obj(isolate()); 5263 ExternalReference::address_of_pending_message_obj(isolate());
5276 __ mov(Operand::StaticVariable(pending_message_obj), edx); 5264 __ mov(Operand::StaticVariable(pending_message_obj), edx);
5277 5265
5278 // Restore result register from stack. 5266 // Restore result register from stack.
5279 __ pop(result_register()); 5267 __ pop(result_register());
5280 5268
5281 // Uncook return address. 5269 // Uncook return address.
5282 __ pop(edx); 5270 __ pop(edx);
5283 __ SmiUntag(edx); 5271 __ SmiUntag(edx);
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
5389 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5377 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5390 Assembler::target_address_at(call_target_address, 5378 Assembler::target_address_at(call_target_address,
5391 unoptimized_code)); 5379 unoptimized_code));
5392 return OSR_AFTER_STACK_CHECK; 5380 return OSR_AFTER_STACK_CHECK;
5393 } 5381 }
5394 5382
5395 5383
5396 } } // namespace v8::internal 5384 } } // namespace v8::internal
5397 5385
5398 #endif // V8_TARGET_ARCH_IA32 5386 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen.h ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698