Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 998943003: Simplify pending message object handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5306 matching lines...) Expand 10 before | Expand all | Expand 10 after
5317 5317
5318 // Store result register while executing finally block. 5318 // Store result register while executing finally block.
5319 __ push(r1); 5319 __ push(r1);
5320 5320
5321 // Store pending message while executing finally block. 5321 // Store pending message while executing finally block.
5322 ExternalReference pending_message_obj = 5322 ExternalReference pending_message_obj =
5323 ExternalReference::address_of_pending_message_obj(isolate()); 5323 ExternalReference::address_of_pending_message_obj(isolate());
5324 __ mov(ip, Operand(pending_message_obj)); 5324 __ mov(ip, Operand(pending_message_obj));
5325 __ ldr(r1, MemOperand(ip)); 5325 __ ldr(r1, MemOperand(ip));
5326 __ push(r1); 5326 __ push(r1);
5327
5328 ExternalReference has_pending_message =
5329 ExternalReference::address_of_has_pending_message(isolate());
5330 __ mov(ip, Operand(has_pending_message));
5331 STATIC_ASSERT(sizeof(bool) == 1); // NOLINT(runtime/sizeof)
5332 __ ldrb(r1, MemOperand(ip));
5333 __ SmiTag(r1);
5334 __ push(r1);
5335 } 5327 }
5336 5328
5337 5329
5338 void FullCodeGenerator::ExitFinallyBlock() { 5330 void FullCodeGenerator::ExitFinallyBlock() {
5339 DCHECK(!result_register().is(r1)); 5331 DCHECK(!result_register().is(r1));
5340 // Restore pending message from stack. 5332 // Restore pending message from stack.
5341 __ pop(r1); 5333 __ pop(r1);
5342 __ SmiUntag(r1);
5343 ExternalReference has_pending_message =
5344 ExternalReference::address_of_has_pending_message(isolate());
5345 __ mov(ip, Operand(has_pending_message));
5346 STATIC_ASSERT(sizeof(bool) == 1); // NOLINT(runtime/sizeof)
5347 __ strb(r1, MemOperand(ip));
5348
5349 __ pop(r1);
5350 ExternalReference pending_message_obj = 5334 ExternalReference pending_message_obj =
5351 ExternalReference::address_of_pending_message_obj(isolate()); 5335 ExternalReference::address_of_pending_message_obj(isolate());
5352 __ mov(ip, Operand(pending_message_obj)); 5336 __ mov(ip, Operand(pending_message_obj));
5353 __ str(r1, MemOperand(ip)); 5337 __ str(r1, MemOperand(ip));
5354 5338
5355 // Restore result register from stack. 5339 // Restore result register from stack.
5356 __ pop(r1); 5340 __ pop(r1);
5357 5341
5358 // Uncook return address and return. 5342 // Uncook return address and return.
5359 __ pop(result_register()); 5343 __ pop(result_register());
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
5528 5512
5529 DCHECK(interrupt_address == 5513 DCHECK(interrupt_address ==
5530 isolate->builtins()->OsrAfterStackCheck()->entry()); 5514 isolate->builtins()->OsrAfterStackCheck()->entry());
5531 return OSR_AFTER_STACK_CHECK; 5515 return OSR_AFTER_STACK_CHECK;
5532 } 5516 }
5533 5517
5534 5518
5535 } } // namespace v8::internal 5519 } } // namespace v8::internal
5536 5520
5537 #endif // V8_TARGET_ARCH_ARM 5521 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698