Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 998943002: the IsPromise function should not execute js (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

the IsPromise function should not execute js BUG=v8:3929 LOG=n Committed: https://crrev.com/b1a5812203a126d36482f7472b1ebcebd37c2474 Cr-Commit-Position: refs/heads/master@{#27130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M src/api.cc View 1 chunk +11 lines, -17 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/contexts.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
lgtm
5 years, 9 months ago (2015-03-11 11:48:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998943002/1
5 years, 9 months ago (2015-03-11 11:51:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 12:14:13 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 12:14:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1a5812203a126d36482f7472b1ebcebd37c2474
Cr-Commit-Position: refs/heads/master@{#27130}

Powered by Google App Engine
This is Rietveld 408576698