Enable MouseEvent buttons attribute by default.

Enable MouseEvent buttons attribute by default.

During any mouse events, buttons must be used to indicate which combination of
mouse buttons are currently being pressed, expressed as a bitmask.

Intent to implement and ship:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tMvB-8CrE3M

Spec:
  http://www.w3.org/TR/DOM-Level-3-Events/#widl-MouseEvent-buttons

BUG=276941
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191974

[zino, 2015-03-12 01:56:43]

jinho.bang@samsung.com changed reviewers:
+ pdr@chromium.org, rbyers@chromium.org

[zino, 2015-03-12 01:56:43]

Please take a look.

Thank you.

[Rick Byers, 2015-03-12 14:15:54]

I support turning this on now, thank you!

https://codereview.chromium.org/998903002/diff/1/Source/core/events/MouseEven...
File Source/core/events/MouseEvent.idl (left):

https://codereview.chromium.org/998903002/diff/1/Source/core/events/MouseEven...
Source/core/events/MouseEvent.idl:34:
[RuntimeEnabled=MouseEventButtonsAttribute] readonly attribute unsigned short  
buttons;
leave this in place for a release - it makes it easy for us to flip back off if
necessary.

https://codereview.chromium.org/998903002/diff/1/Source/platform/RuntimeEnabl...
File Source/platform/RuntimeEnabledFeatures.in (left):

https://codereview.chromium.org/998903002/diff/1/Source/platform/RuntimeEnabl...
Source/platform/RuntimeEnabledFeatures.in:90: MouseEventButtonsAttribute
status=experimental
Just set this to status=stable for now

[zino, 2015-03-16 02:53:06]

Thank you for review.

PTAL,

[Rick Byers, 2015-03-16 19:56:01]

LGTM

[zino, 2015-03-17 00:33:37]

Patchset #3 (id:40001) has been deleted

[zino, 2015-03-17 00:39:26]

Ping @pdr,

This is a small web-exposed change.

So, I think this needs your approval. (API owner)

Could you take a look?

Thank you.

[pdr., 2015-03-17 02:17:51]

On 2015/03/17 at 00:39:26, jinho.bang wrote:
> Ping @pdr,
> 
> This is a small web-exposed change.
> 
> So, I think this needs your approval. (API owner)
> 
> Could you take a look?
> 
> Thank you.

LGTM

In this case you already have 3 LGTMs on the public blink-dev thread so you just
needed an owner from Source/platform.

[pdr., 2015-03-17 02:17:55]

The CQ bit was checked by pdr@chromium.org

[pdr., 2015-03-17 02:17:55]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/998903002/#ps60001 (title:
" ")

[commit-bot: I haz the power, 2015-03-17 02:18:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/998903002/60001

[commit-bot: I haz the power, 2015-03-17 04:27:51]

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191974