Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 998893002: [scanner] Extend fast-smi parsing to the entire range minus Smi::kMinValue (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[scanner] Extend fast-smi parsing to the entire range minus Smi::kMinValue BUG= Committed: https://crrev.com/e77d0abd4aca48ce9703ce560823dc80aa7e0c08 Cr-Commit-Position: refs/heads/master@{#27129}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M src/scanner.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/scanner.cc View 1 3 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
PTAL on x64 this supports parsing of all int32 values (minus min_int) as smi.
5 years, 9 months ago (2015-03-11 09:33:27 UTC) #2
Yang
On 2015/03/11 09:33:27, Toon Verwaest wrote: > PTAL > > on x64 this supports parsing ...
5 years, 9 months ago (2015-03-11 10:08:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998893002/1
5 years, 9 months ago (2015-03-11 10:24:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/3851)
5 years, 9 months ago (2015-03-11 10:40:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998893002/20001
5 years, 9 months ago (2015-03-11 11:11:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-11 11:33:23 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 11:33:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e77d0abd4aca48ce9703ce560823dc80aa7e0c08
Cr-Commit-Position: refs/heads/master@{#27129}

Powered by Google App Engine
This is Rietveld 408576698