Increase MessageAttachmentSet::kMaxDescriptorsPerMessage

ppapi/tests/extensions/packaged_app/test_packaged_app.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <pthread.h>
 #include <unistd.h>
 
 #include <sstream>
 #include <string>
 
 #include "native_client/src/untrusted/irt/irt.h"
 
 #include "ppapi/cpp/completion_callback.h"
 #include "ppapi/cpp/instance.h"
 #include "ppapi/cpp/module.h"
 #include "ppapi/cpp/tcp_socket.h"
 #include "ppapi/cpp/var.h"
 #include "ppapi/utility/completion_callback_factory.h"
 
 namespace {
 
 std::string g_last_error;
 pp::Instance* g_instance = NULL;
 
-// This should be the same as FileDescriptorSet::kMaxDescriptorsPerMessage in
-// ipc/file_descriptor_set_posix.h.
+// This should be the same as MessageAttachmentSet::kMaxDescriptorsPerMessage in
+// ipc/ipc_message_attachment_set.h.
 // TODO(yusukes): Once all the NaCl toolchains support C++11, Add

[Mark Seaborn, 2015/03/16 17:06:50]

Which NaCl toolchains does "ipc/file_descriptor_set_posix.h" not work with? 
Which toolchains does this file get compiled with?

If this is getting compiled with both the old nacl-gcc and the up-to-date Clang,
can you add a check conditionalised on "#if defined(__clang__)"?

[Yusuke Sato, 2015/03/16 21:27:28]

At least '../../../native_client/build/build_nexe.py ...  --arch x86-64 --build
newlib_nexe' is not compatible with the header.

Adding __clang__ is a very good idea and I've confirmed it works as expected,
but it also requires a DEPS change. Let me do that in a subsequent change. I'll
send it to you today.

 // #include "ipc/file_descriptor_set_posix.h" and remove the constant.
-const size_t kMaxDescriptorsPerMessage = 7;
+const size_t kMaxDescriptorsPerMessage = 128;
 
 // Returns true if the resource file whose name is |key| exists and its content
 // matches |content|.
 bool LoadManifestInternal(nacl_irt_resource_open* nacl_irt_resource_open,
                           const std::string& key,
                           const std::string& content) {
   int desc;
   int error;
   error = nacl_irt_resource_open->open_resource(key.c_str(), &desc);
   if (0 != error) {
@@ skipping 119 matching lines @@
 
 }  // namespace
 
 namespace pp {
 
 Module* CreateModule() {
   return new MyModule();
 }
 
 }  // namespace pp