Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 99883003: Explicit PrefixSet test prefix distribution. (Closed)

Created:
7 years ago by Scott Hess - ex-Googler
Modified:
7 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

Explicit PrefixSet test prefix distribution. Previously, the shared prefixes used a count which would (often) cause multiple prefixes to end up within 2^16 of each other. Modify the setup to explicitly generate both denser and sparser clusters, to allow reducing the overall number of prefixes required. BUG=65151 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/safe_browsing/prefix_set_unittest.cc View 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Hess - ex-Googler
7 years ago (2013-12-02 22:10:20 UTC) #1
Paweł Hajdan Jr.
LGTM, thank you. :)
7 years ago (2013-12-02 23:36:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/99883003/1
7 years ago (2013-12-03 00:03:47 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-03 02:30:13 UTC) #4
Message was sent while issue was closed.
Change committed as 238273

Powered by Google App Engine
This is Rietveld 408576698