net/sdch/sdch_owner.h - Issue 998803003: Checks to enforce relative lifetimes for SdchManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/sdch/sdch_owner.h

Issue 998803003: Checks to enforce relative lifetimes for SdchManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated comments and fixed else clause. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/sdch/sdch_owner.h

diff --git a/net/sdch/sdch_owner.h b/net/sdch/sdch_owner.h

index a187a6e0b56c3d2cb5ed0afdc1fdceee18693e75..134bb86df7d7e8693fe9d3e8414b64c750167216 100644

--- a/net/sdch/sdch_owner.h

+++ b/net/sdch/sdch_owner.h

@@ -10,6 +10,7 @@

#include "base/memory/memory_pressure_listener.h"

#include "base/memory/ref_counted.h"

+#include "base/memory/weak_ptr.h"

#include "base/prefs/pref_store.h"

#include "net/base/sdch_observer.h"

#include "net/url_request/sdch_dictionary_fetcher.h"

@@ -115,7 +116,8 @@ class NET_EXPORT SdchOwner : public net::SdchObserver,

bool IsPersistingDictionaries() const;

- net::SdchManager* manager_;

+ // For investigation of http://crbug.com/454198; remove when resolved.

+ base::WeakPtr<net::SdchManager> manager_;

scoped_ptr<net::SdchDictionaryFetcher> fetcher_;

size_t total_dictionary_bytes_;

« no previous file with comments | « net/base/sdch_manager.cc ('k') | net/sdch/sdch_owner.cc » ('j') | no next file with comments »