Checks to enforce relative lifetimes for SdchManager.

net/url_request/url_request_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_context.h"
 
 #include "base/compiler_specific.h"
 #include "base/debug/alias.h"
 #include "base/debug/stack_trace.h"
 #include "base/strings/string_util.h"
@@ skipping 13 matching lines @@
       fraudulent_certificate_reporter_(NULL),
       http_auth_handler_factory_(NULL),
       proxy_service_(NULL),
       network_delegate_(NULL),
       http_user_agent_settings_(NULL),
       transport_security_state_(NULL),
       cert_transparency_verifier_(NULL),
       http_transaction_factory_(NULL),
       job_factory_(NULL),
       throttler_manager_(NULL),
-      sdch_manager_(NULL),
+      // For investigation of http://crbug.com/454198; restore when resolved.
+      // sdch_manager_(NULL),
+      have_sdch_manager_(false),
       url_requests_(new std::set<const URLRequest*>) {
 }
 
 URLRequestContext::~URLRequestContext() {
   AssertNoURLRequests();
 }
 
 void URLRequestContext::CopyFrom(const URLRequestContext* other) {
   // Copy URLRequestContext parameters.
   set_net_log(other->net_log_);
   set_host_resolver(other->host_resolver_);
   set_cert_verifier(other->cert_verifier_);
   set_channel_id_service(other->channel_id_service_);
   set_fraudulent_certificate_reporter(other->fraudulent_certificate_reporter_);
   set_http_auth_handler_factory(other->http_auth_handler_factory_);
   set_proxy_service(other->proxy_service_);
   set_ssl_config_service(other->ssl_config_service_.get());
   set_network_delegate(other->network_delegate_);
   set_http_server_properties(other->http_server_properties_);
   set_cookie_store(other->cookie_store_.get());
   set_transport_security_state(other->transport_security_state_);
   set_cert_transparency_verifier(other->cert_transparency_verifier_);
   set_http_transaction_factory(other->http_transaction_factory_);
   set_job_factory(other->job_factory_);
   set_throttler_manager(other->throttler_manager_);
-  set_sdch_manager(other->sdch_manager_);
+  // For investigation of http://crbug.com/454198; remove when resolved.
+  CHECK(!other->have_sdch_manager_ || other->sdch_manager_.get());
+  set_sdch_manager(other->sdch_manager_.get());
   set_http_user_agent_settings(other->http_user_agent_settings_);
 }
 
 const HttpNetworkSession::Params* URLRequestContext::GetNetworkSessionParams(
     ) const {
   HttpTransactionFactory* transaction_factory = http_transaction_factory();
   if (!transaction_factory)
     return NULL;
   HttpNetworkSession* network_session = transaction_factory->GetSession();
   if (!network_session)
@@ skipping 32 matching lines @@
     base::debug::Alias(&num_requests);
     base::debug::Alias(&has_delegate);
     base::debug::Alias(&load_flags);
     base::debug::Alias(&stack_trace);
     CHECK(false) << "Leaked " << num_requests << " URLRequest(s). First URL: "
                  << request->url().spec().c_str() << ".";
   }
 }
 
 }  // namespace net