Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 998803002: Make the search box in the stocks app show a search field (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the search box in the stocks app show a search field The search field doesn't do anything, but it's there. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b23e83a8b93a801a680f9da9673f77ffa299d646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -14 lines) Patch
M sky/examples/stocks-fn/stocks.sky View 1 chunk +1 line, -0 lines 0 comments Download
M sky/examples/stocks-fn/stocksapp.dart View 4 chunks +14 lines, -2 lines 0 comments Download
M sky/framework/components/input.dart View 2 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-10 23:38:35 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-10 23:40:42 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-11 00:17:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b23e83a8b93a801a680f9da9673f77ffa299d646 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698