Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 998733002: handler/mac: Forward exceptions to the system crash reporter (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

handler/mac: Forward exceptions to the system crash reporter. TEST=run_with_crashpad --handler crashpad_handler \ -a --database=/tmp/crashpad_db \ -a --url=https://clients2.google.com/cr/staging_report \ -a --annotation=prod=crashpad \ -a --annotation=ver=0.7.0 \ crashy_program R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b8d2129bc1c06410babb93d2704b686fc34bb93f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M handler/mac/crash_report_exception_handler.cc View 2 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-10 20:33:41 UTC) #2
Robert Sesek
How will we disable this for things like renderer crashes and CHROME_HEADLESS=1?
5 years, 9 months ago (2015-03-10 20:45:49 UTC) #3
Mark Mentovai
The next change will add a method to the client interface to disable Crashpad processing ...
5 years, 9 months ago (2015-03-10 21:02:41 UTC) #4
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-10 21:09:12 UTC) #5
Mark Mentovai
5 years, 9 months ago (2015-03-10 21:10:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8d2129bc1c06410babb93d2704b686fc34bb93f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698