Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 998693003: Subzero: Enable a cmake build. (Closed)

Created:
5 years, 9 months ago by Jim Stichnoth
Modified:
5 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Enable a cmake build. This just puts the CMakeLists.txt file in place. A couple other changes are needed in other repos to make this take effect. BUG= none R=dschuff@chromium.org, mtrofin@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cd912149a6ea02cc0e5d51884f220c1f9f4870c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
A CMakeLists.txt View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jim Stichnoth
This is the cmake equivalent of the regular, non-MINIMAL build. It will need some changes ...
5 years, 9 months ago (2015-03-10 21:01:37 UTC) #3
Derek Schuff
On 2015/03/10 21:01:37, stichnot wrote: > This is the cmake equivalent of the regular, non-MINIMAL ...
5 years, 9 months ago (2015-03-10 21:19:49 UTC) #4
Mircea Trofin
lgtm
5 years, 9 months ago (2015-03-10 21:20:35 UTC) #5
Jim Stichnoth
5 years, 9 months ago (2015-03-10 21:34:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd912149a6ea02cc0e5d51884f220c1f9f4870c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698