Added CrOS-specific OAuth2 browser test.

Added CrOS-specific OAuth2 browser test.

Expanded FakeGaia class to cover all other auth related calls.

BUG=none
TEST=OAuth2Test.*
R=rogerta@chromium.org, xiyuan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241389

[Roger Tawa OOO till Jul 10th, 2013-12-16 20:44:36]

google_apis lgtm

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
File google_apis/gaia/fake_gaia.cc (right):

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
google_apis/gaia/fake_gaia.cc:99: // Handles /o/oauth2/token GAIA call.
Same as line 87 above?

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
File google_apis/gaia/fake_gaia.h (right):

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
google_apis/gaia/fake_gaia.h:52: // Sets the initial |auth_code| and OAuth2
|refresh_token| and |access_token|.
Nit: not not want to refer to the arg names directly, since only 3 of 6 are
mentioned.  Maybe just say:

// Sets the initial value of tokens and cookies.

[xiyuan, 2013-12-16 21:04:55]

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/oauth2_browsertest.cc (right):

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oauth2_browsertest.cc:22: const int
kTestNetworkTimeoutSeconds = 1;
Seems not used.

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oauth2_browsertest.cc:43: const char
kStubEthernetServicePath[] = "eth1";
Seems not used.

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oauth2_browsertest.cc:46: void
OnNetworkWaitTimedOut(const base::Closure& runner_quit_task) {
Seems not used.

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oauth2_browsertest.cc:152:
login_manager->RemoveObserver(this);
This is not necessary since we do that on line 134 after return from
runner_->Run().

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/oobe_base_test.cc (right):

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oobe_base_test.cc:51:
"https://www.googleapis.com/auth/userinfo.profile";
Line 36 - 51 seems not used.

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oobe_base_test.cc:78:
AppLaunchController::SetNetworkWaitForTesting(kTestNetworkTimeoutSeconds);
|mock_user_manager_| and the two AppLaunchController calls are related to kiosk
tests only and should stay in KioskTest.

|mock_user_manager_| is only used for the fake owner signin screen in
KioskTest.LaunchAppNetworkDown. It is not used for the initial login screen.

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
File google_apis/gaia/fake_gaia.h (right):

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
google_apis/gaia/fake_gaia.h:80: // Formats a JSON response with the data in
|response_dict|.
nit: change seems unintentional. revert?

[zel, 2013-12-16 21:27:38]

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/oauth2_browsertest.cc (right):

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oauth2_browsertest.cc:22: const int
kTestNetworkTimeoutSeconds = 1;
On 2013/12/16 21:04:55, xiyuan wrote:
> Seems not used.

Done.

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oauth2_browsertest.cc:43: const char
kStubEthernetServicePath[] = "eth1";
On 2013/12/16 21:04:55, xiyuan wrote:
> Seems not used.

Done.

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oauth2_browsertest.cc:46: void
OnNetworkWaitTimedOut(const base::Closure& runner_quit_task) {
On 2013/12/16 21:04:55, xiyuan wrote:
> Seems not used.

Done.

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oauth2_browsertest.cc:152:
login_manager->RemoveObserver(this);
On 2013/12/16 21:04:55, xiyuan wrote:
> This is not necessary since we do that on line 134 after return from
> runner_->Run().

Done.

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/oobe_base_test.cc (right):

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oobe_base_test.cc:51:
"https://www.googleapis.com/auth/userinfo.profile";
On 2013/12/16 21:04:55, xiyuan wrote:
> Line 36 - 51 seems not used.

Done.

https://codereview.chromium.org/99863007/diff/140001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/oobe_base_test.cc:78:
AppLaunchController::SetNetworkWaitForTesting(kTestNetworkTimeoutSeconds);
On 2013/12/16 21:04:55, xiyuan wrote:
> |mock_user_manager_| and the two AppLaunchController calls are related to
kiosk
> tests only and should stay in KioskTest.
> 
> |mock_user_manager_| is only used for the fake owner signin screen in
> KioskTest.LaunchAppNetworkDown. It is not used for the initial login screen.

Done.

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
File google_apis/gaia/fake_gaia.cc (right):

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
google_apis/gaia/fake_gaia.cc:99: // Handles /o/oauth2/token GAIA call.
On 2013/12/16 20:44:37, Roger Tawa wrote:
> Same as line 87 above?

Done.

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
File google_apis/gaia/fake_gaia.h (right):

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
google_apis/gaia/fake_gaia.h:52: // Sets the initial |auth_code| and OAuth2
|refresh_token| and |access_token|.
On 2013/12/16 20:44:37, Roger Tawa wrote:
> Nit: not not want to refer to the arg names directly, since only 3 of 6 are
> mentioned.  Maybe just say:
> 
> // Sets the initial value of tokens and cookies.

Done.

https://codereview.chromium.org/99863007/diff/140001/google_apis/gaia/fake_ga...
google_apis/gaia/fake_gaia.h:80: // Formats a JSON response with the data in
|response_dict|.
On 2013/12/16 21:04:55, xiyuan wrote:
> nit: change seems unintentional. revert?

Done.

[xiyuan, 2013-12-16 21:32:55]

lgtm

[commit-bot: I haz the power, 2013-12-16 21:37:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/99863007/180001

[commit-bot: I haz the power, 2013-12-17 00:25:17]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-17 02:37:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/99863007/180001

[commit-bot: I haz the power, 2013-12-17 05:25:00]

Failed to trigger a try job on linux_chromeos_clang
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-12-17 05:25:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/99863007/190001

[commit-bot: I haz the power, 2013-12-17 08:07:09]

Failed to apply patch for chrome/chrome_tests.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/chrome_tests.gypi
  Hunk #1 FAILED at 1021.
  1 out of 1 hunk FAILED -- saving rejects to file chrome/chrome_tests.gypi.rej

Patch:       chrome/chrome_tests.gypi
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index
5351f5d96cbf784a0605ecec04ee515fe0fe23fd..daa8bb38b8acb995054d116315be1b9f93027fda
100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -1021,6 +1021,9 @@
        
'browser/chromeos/login/managed/supervised_user_creation_browsertest.cc',
         'browser/chromeos/login/mock_authenticator.cc',
         'browser/chromeos/login/mock_authenticator.h',
+        'browser/chromeos/login/oauth2_browsertest.cc',
+        'browser/chromeos/login/oobe_base_test.cc',
+        'browser/chromeos/login/oobe_base_test.h',
         'browser/chromeos/login/session_login_browsertest.cc',
         'browser/chromeos/login/screen_locker_tester.cc',
         'browser/chromeos/login/screen_locker_tester.h',

[commit-bot: I haz the power, 2013-12-17 16:42:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/99863007/210001

[xiyuan, 2013-12-17 16:52:36]

Thanks for the merge. :)

https://codereview.chromium.org/99863007/diff/210001/google_apis/gaia/fake_ga...
File google_apis/gaia/fake_gaia.cc (right):

https://codereview.chromium.org/99863007/diff/210001/google_apis/gaia/fake_ga...
google_apis/gaia/fake_gaia.cc:229: void FakeGaia::HandleSSO(const HttpRequest&
request,
Do we need to REGISTER_RESPONSE_HANDLER HandleSSO with '/SSO'?

/SSO is the hardcoded path used in FakeSamlIdp of SAMLTest.

[zel, 2013-12-17 17:10:30]

https://codereview.chromium.org/99863007/diff/210001/google_apis/gaia/fake_ga...
File google_apis/gaia/fake_gaia.cc (right):

https://codereview.chromium.org/99863007/diff/210001/google_apis/gaia/fake_ga...
google_apis/gaia/fake_gaia.cc:229: void FakeGaia::HandleSSO(const HttpRequest&
request,
On 2013/12/17 16:52:37, xiyuan wrote:
> Do we need to REGISTER_RESPONSE_HANDLER HandleSSO with '/SSO'?
> 
> /SSO is the hardcoded path used in FakeSamlIdp of SAMLTest.

Done.

[commit-bot: I haz the power, 2013-12-17 17:31:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/99863007/230001

[commit-bot: I haz the power, 2013-12-17 18:27:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/99863007/230001

[commit-bot: I haz the power, 2013-12-17 19:53:01]

Failed to trigger a try job on linux_chromeos
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-12-17 19:53:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/99863007/250001

[commit-bot: I haz the power, 2013-12-17 22:19:58]

Failed to apply the patch.
<?xml version="1.0"?>
<status>
<target
   path=".">

[zel, 2013-12-17 22:27:00]

Committed patchset #14 manually as r241389 (presubmit successful).